-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HtsGetVCFReader implementation? #1555
Comments
Hey all. If the motivation for this is IGV I think I could implement support in IGV in a fairly straightforward manner with a custom FeatureSource, the implementation would use a VCF codec from Tribble but everything else in IGV. For background I created Tribble, the concept of "codecs" for parsing features, etc with input from Mark DePristo (who named it after a star trek episode) so I have background there. I could implement this in the htsjdk but the overhead for me to do so is large enough that it would take longer, and be harder for me to squeeze in. |
I love that TOS Star Trek episode :) Jim, that's what me and @reisingerf suspected after a fair bit of head scratching going through IGV's code. Although I'd prefer this feature to be supported within htsjdk itself (design principles), I totally get and respect your analysis. So If no htsjdk developer steps up for this, could you finish up this part within IGV via tribbles? We could then close the GA4GH htsget-supported-in-BOTH-IGV.js-and-IGV-desktop support meta-ticket for good, I reckon :) |
Sure, although I'm leaving for vacation tomorrow so it might be a few weeks. Do we have an issue for this in IGV? I had not seen that star trek episode, but Mark imagined codecs proliferating like tribbles (if that's what they are called). "Picard" also has a ST connection. |
No rush on this, I just opened the issue on IGV, enjoy the break Jim! Bioinformatics is so full of tribbles and many troubles... most of them are not as cute as the ST furry animals though. |
…see issues samtools/htsjdk#1555 and igvteam#983 for context
@lbergelson @lindenb I'm currently implementing support for I've got BAM reading through our htsget server working alright, but looking for Is there currently a suitable alternative/factory to read VCF/BCF assets through htsget in a similar way than with SAM/BAM? |
Description of the issue:
While implementing support for htsget in IGV-desktop, we (@reisingerf and @brainstorm) noticed that there's no
htsgetVariantsReader
or any similar reader akin to htsgetbamreader.In other words, we need to wrap htsjdk variant readers for VCF/BCF like we did for BAM (working on the IGV PR/branch referred above): https://github.com/igvteam/igv/blob/67a0a8be361b92cfeabc1048c9be26f5a37c7ec6/src/main/java/org/broad/igv/sam/reader/HtsgetBAMReader.java
We suspect that there's similar ongoing work to attain this on #1551 ?... although there's no explicit mention of "htsget", the issue seems to suggest an abstraction away from regular files on local disk.
/cc @mlin @ohofmann @jrobinso @lindenb @lbergelson
The text was updated successfully, but these errors were encountered: