From 17825cdbffd6e8f80aa4f4b5f3967121af4cbdcb Mon Sep 17 00:00:00 2001 From: Mats Johansen Date: Tue, 23 Jan 2024 10:37:57 +0100 Subject: [PATCH 1/3] fix(result summary): change info button to svelte component --- .../src/components/results/ResultSummaryComponent.wc.svelte | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/lib/src/components/results/ResultSummaryComponent.wc.svelte b/packages/lib/src/components/results/ResultSummaryComponent.wc.svelte index f6116a8e..88c5d0bd 100644 --- a/packages/lib/src/components/results/ResultSummaryComponent.wc.svelte +++ b/packages/lib/src/components/results/ResultSummaryComponent.wc.svelte @@ -68,6 +68,7 @@ lens-info-button::part(info-button-dialogue) { getAggregatedPopulationForStratumCode, } from "../../stores/response"; import type { ResponseStore } from "../../types/backend"; + import InfoButtonComponent from "../buttons/InfoButtonComponent.wc.svelte"; let options: any = {}; @@ -154,7 +155,7 @@ lens-info-button::part(info-button-dialogue) {
- Date: Tue, 23 Jan 2024 10:50:02 +0100 Subject: [PATCH 2/3] ci: renamed docker image With repository rename, also the docker image needs to be renamed --- .github/workflows/docker-develop.yml | 2 +- .github/workflows/docker.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/docker-develop.yml b/.github/workflows/docker-develop.yml index 8c0fd6c7..1b92ad28 100644 --- a/.github/workflows/docker-develop.yml +++ b/.github/workflows/docker-develop.yml @@ -13,7 +13,7 @@ jobs: # Visit: https://github.com/samply/github-workflows/blob/main/.github/workflows/docker-ci.yml, for more information uses: samply/github-workflows/.github/workflows/docker-ci.yml@main with: - image-name: "samply/lens-web-components" + image-name: "samply/lens" build-args: | TARGET_ENVIRONMENT=staging # This passes the secrets from calling workflow to the called workflow diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index fc27b8b4..ab68da45 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -19,7 +19,7 @@ jobs: # Visit: https://github.com/samply/github-workflows/blob/main/.github/workflows/docker-ci.yml, for more information uses: samply/github-workflows/.github/workflows/docker-ci.yml@main with: - image-name: "samply/lens-web-components" + image-name: "samply/lens" build-args: | TARGET_ENVIRONMENT=production # This passes the secrets from calling workflow to the called workflow From 17451c99c0e7a721022c20844848d98377078814 Mon Sep 17 00:00:00 2001 From: Mats Johansen Date: Tue, 23 Jan 2024 10:54:46 +0100 Subject: [PATCH 3/3] feat(result summary): add style to info button --- .../src/styles/default/results-overview.css | 32 ++++++++++++++++++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/packages/demo/src/styles/default/results-overview.css b/packages/demo/src/styles/default/results-overview.css index 8b8b3cfd..9b99b574 100644 --- a/packages/demo/src/styles/default/results-overview.css +++ b/packages/demo/src/styles/default/results-overview.css @@ -16,4 +16,34 @@ lens-result-summary { align-items: center; justify-content: space-around; gap: 10px - } \ No newline at end of file + } + + lens-result-summary::part(info-button) { + position: relative; + cursor: pointer; + height: 100%; + border: none; + background-color: var(--white); + border-radius: var(--border-radius-small); +} + lens-result-summary::part(info-button-icon) { + width: 16px; +} + +lens-result-summary::part(info-button-title) { + font-family: var(--font-family); +} + +lens-result-summary::part(info-button-dialogue) { + position: absolute; + border: none; + background-color: var(--white); + width: max-content; + max-width: 30vw; + z-index: 100; + padding: var(--gap-s); + top: 40px; + left: 0px; + border: solid 1px var(--light-blue); + border-radius: var(--border-radius-small); +}