Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status on todo item #3? #5

Open
nathanpeck opened this issue May 4, 2015 · 2 comments
Open

Status on todo item #3? #5

nathanpeck opened this issue May 4, 2015 · 2 comments

Comments

@nathanpeck
Copy link

If Open Graph data isn't present, scrap img elements and document titles off the page.

I am interested in developing and adding this feature for usage by the startup I work for, as well as for contributing back to the open source community. Just wanted to see if you have done anything on this yet (maybe a dev branch I can use a starting point) or if you are open to merging it in if I add this feature.

@samholmes
Copy link
Owner

I'd definitely be interested in pull requests. I've been meaning to put more effort into this project for way too long. Any help is appreciated actually.

My goal was to eventually rewrite the parse method to fallback to non-open-graph elements on the page. If this is something you feel is worth your time, please do so and send a PR on over.

PS: Sorry for the late reply.

@nathanpeck
Copy link
Author

I did end up coding it myself, but was not able to get approval to open source it and contribute back unfortunately. But for anyone out there who needs this its not too hard. I can probably even recreate the code from scratch again outside of work hours if I can get the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants