Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you add support for image sitemap? #90

Open
jasomdotnet opened this issue May 28, 2022 · 5 comments
Open

Can you add support for image sitemap? #90

jasomdotnet opened this issue May 28, 2022 · 5 comments

Comments

@jasomdotnet
Copy link

Hi,

I like this repo - so far the simpliest (no stupid requirements) with best documentation. Can you add support for image sitemap? Kindly see this:

@jasomdotnet
Copy link
Author

I'd like to add it but currently have not enough time for it. A pull request is welcome though.

Yes, I see it as pull request too :D

@jasomdotnet
Copy link
Author

Add images to an existing sitemap, or create a separate sitemap just for your images.

In order to support image sitemap you basically add new sub-lines according this scheme:

<?xml version="1.0" encoding="UTF-8"?>
<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9"
        xmlns:image="http://www.google.com/schemas/sitemap-image/1.1">
  <url>
    <loc>http://example.com/sample1.html</loc>
    <image:image>
      <image:loc>http://example.com/image.jpg</image:loc>
    </image:image>
    <image:image>
      <image:loc>http://example.com/photo.jpg</image:loc>
    </image:image>
  </url>
  <url>
    <loc>http://example.com/sample2.html</loc>
    <image:image>
      <image:loc>http://example.com/picture.jpg</image:loc>
    </image:image>
  </url>
</urlset>

This increases sitemap.xml file-size. So what about "file-limits" in the case of increasing total generating code. This repo counts overall file-size automatically or in potential pull request I need to alter also "file-limits" part?

@samdark
Copy link
Owner

samdark commented May 29, 2022

This repo counts overall file-size automatically or in potential pull request I need to alter also "file-limits" part?

It should count it well but that should be re-checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants