Loading Docker client from environment variables?

[nathanleclaire]

It would be nice if there was a method such as NewDockerClientEnv which automatically loaded the correct thing based on the environment variables such as DOCKER_HOST, DOCKER_CERT_PATH, etc. The code would be something like:

func NewDockerClientEnv() (*DockerClient, error) {
        tlsc := &tls.Config{}
        dockerCertPath := os.Getenv("DOCKER_CERT_PATH")

        cert, err := tls.LoadX509KeyPair(filepath.Join(dockerCertPath, "cert.pem"), filepath.Join(dockerCertPath, "key.pem"))
        if err != nil {
                return nil, fmt.Errorf("Error loading x509 key pair: %s", err)
        }

        tlsc.Certificates = append(tlsc.Certificates, cert)
        tlsc.InsecureSkipVerify = true

        dc, err := dockerclient.NewDockerClient(os.Getenv("DOCKER_HOST"), tlsc)
        if err != nil {
                return nil, fmt.Errorf("Error getting Docker Client: %s", err)
        }

        return dc, nil
}

I could submit a PR if there is interest. Interested?

[keegancsmith]

I submitted #201 which does a part of this. For an example usage check out https://github.com/drone/drone-exec/pull/13
I can flesh out that PR further by adding a NewDockerClientEnv, but to match the same functionality as the official docker client is a bit more work.