Handle new-initiator/new-responder correctly #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgrahl
force-pushed
the
61-handle-new-peer-correctly
branch
from
915d461
to
80f3ff7
Compare
This can happen since a message from a responder towards an initiator may still be in flight after the initiator dropped the responder.
Note that this deviates from the intention of the specification to allow for more than one connection towards a responder over the same WebSocket connection.
Note that this deviates from the intention of the specification to allow for more than one connection towards an initiator over the same WebSocket connection.
lgrahl
force-pushed
the
61-handle-new-peer-correctly
branch
from
80f3ff7
to
5381889
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #61
Merge after #59 #67
To do (@dbrgn): We still need to figure out how to close the task loop after the WebSocket close message has been enqueued. The issue can be reproduced by...