Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Refactor formula to align args / environment handling #62

Open
B1ue-W01f opened this issue Jun 29, 2021 · 0 comments
Open

[BUG] Refactor formula to align args / environment handling #62

B1ue-W01f opened this issue Jun 29, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@B1ue-W01f
Copy link

Your setup

Formula commit hash / release tag

n/a

Versions reports (master & minion)

n/a

Pillar / config used

repo pillar within formula.


Bug details

Describe the bug

The current implementation has a range of potentially duplicate pillars for handling command ARGs.

Such as:

service:
  args:
environ:
  args:
environ_config:
args_file:

The benefit of these duplicates are unclear though they appear to be used in different parts of the formula. This however results in necessity to duplicate work and potential confusion with implementation.

Steps to reproduce the bug

n/a

Expected behaviour

Align the approach to ARG handling at least as far as the pillar is concerned.

Attempts to fix the bug

Pull #60 followed guidance to deliver the solution using the environ file rather than implementing through services, which appears to be the most consistent approach considering best practice and the package maintainers intentions.

@B1ue-W01f B1ue-W01f added the bug Something isn't working label Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant