Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMF node names for FG roots in FGChain #20

Open
barakr opened this issue Nov 19, 2015 · 0 comments
Open

RMF node names for FG roots in FGChain #20

barakr opened this issue Nov 19, 2015 · 0 comments
Assignees

Comments

@barakr
Copy link
Collaborator

barakr commented Nov 19, 2015

I omitted the "root" suffix from FG chains in commit fee26c since it renders RMF files within old restart protobuf files incompatible (e.g. in benchmark_full), due to a usage check from rmf/include/atom_links.cpp in add_links_recursive, that expects the old FG chain name to remain the same.

What needs to be done is to add some versioning to the RMF file, or in the restart output file, that says that if an output file is old, the chain names will be in the old form for consistency, and otherwise be changed.

@barakr barakr self-assigned this Nov 19, 2015
barakr added a commit that referenced this issue Nov 19, 2015
…maintain compatibility with old rmf files. See issue #20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant