Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem running 1.0.6 and 1.0.7 with proto.lock checked in. #31

Open
lastcmaster opened this issue Aug 25, 2021 · 5 comments
Open

Problem running 1.0.6 and 1.0.7 with proto.lock checked in. #31

lastcmaster opened this issue Aug 25, 2021 · 5 comments

Comments

@lastcmaster
Copy link

When running the plugin 1.0.6 or 1.0.7, I get the following error on proto.lock when stored with version control:

[INFO] --- proto-backwards-compatibility:1.0.7:backwards-compatibility-check (default) @ jcute-serdoc ---
[INFO] protolock cmd line: /Users/glz/projects/depot/common/jcute/4.2/main/jcute-serdoc/target/protolock-bin/protolock status --lockdir=/Users/glz/projects/depot/common/jcute/4.2/main/jcute-serdoc/src/main/proto --protoroot=/Users/glz/projects/depot/common/jcute/4.2/main/jcute-serdoc/src/main/proto debug
[INFO] protolock cmd line: /Users/glz/projects/depot/common/jcute/4.2/main/jcute-serdoc/target/protolock-bin/protolock commit --lockdir=/Users/glz/projects/depot/common/jcute/4.2/main/jcute-serdoc/src/main/proto --protoroot=/Users/glz/projects/depot/common/jcute/4.2/main/jcute-serdoc/src/main/proto debug
[INFO] open /Users/glz/projects/depot/common/jcute/4.2/main/jcute-serdoc/src/main/proto/proto.lock: permission denied

When the change is committed, the file is set to read only and in 1.0.6 the flow was changed to always force a protolock commit while 1.0.5 only ran the status command

[INFO] --- proto-backwards-compatibility:1.0.5:backwards-compatibility-check (default) @ jcute-serdoc ---
[INFO] Backwards compatibility check passed.

So the proto.lock file must always be checked out for a build but that collides with the need to have all files checked in for a released build.

We need a flag or option to only run the status check fo released builds.

@rmichela
Copy link
Collaborator

rmichela commented Aug 28, 2021

What version control system are you using that requires files to be preemptively checked out to be opened RW, even if there are no modifications?

@lastcmaster
Copy link
Author

Perforce

@lastcmaster
Copy link
Author

Patch to fix perforce compatibility with no change in function for git users.
[p4compat.patch.gz](https://github.com/salesforce/proto-backwards-compat-maven-
plugin/files/9292362/p4compat.patch.gz)

@rmichela
Copy link
Collaborator

rmichela commented Aug 9, 2022

Thank you! Is it possible to submit this as a PR?

@lastcmaster
Copy link
Author

PR sent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants