fix: obscure dynamic value test case triggering v2 failure (#5172)

* fix: unlikely test triggering v2 failure * fix: remove expected failre entry * fix: remove consumption of function * fix: updated expected file
salesforce · Jan 28, 2025 · d4872a2 · d4872a2
1 parent bb51f84
commit d4872a2
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 12 deletions.
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/render-dynamic-value/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/render-dynamic-value/expected.html
@@ -39,13 +39,6 @@
     <div data-foo="[object Object]">
       [object Object]
     </div>
-    <div data-foo="function whoWouldDoThis() {
-      return 'somebody, probably!';
-    }">
-      function whoWouldDoThis() {
-      return &#x27;somebody, probably!&#x27;;
-    }
-    </div>
     <div data-foo="ooo eee, ooo ah ah, ting tang, walla walla, bing bang">
       ooo eee, ooo ah ah, ting tang, walla walla, bing bang
     </div>

diff --git a/...ine-server/src/__tests__/fixtures/render-dynamic-value/modules/x/component/component.html b/...ine-server/src/__tests__/fixtures/render-dynamic-value/modules/x/component/component.html
@@ -12,7 +12,6 @@
   <div data-foo={isSymbol}>{isSymbol}</div>
   <div data-foo={isArray}>{isArray}</div>
   <div data-foo={isObject}>{isObject}</div>
-  <div data-foo={isFunction}>{isFunction}</div>
   <div data-foo={isString}>{isString}</div>
   <div data-foo={isNumber}>{isNumber}</div>
 </template>
diff --git a/...ngine-server/src/__tests__/fixtures/render-dynamic-value/modules/x/component/component.js b/...ngine-server/src/__tests__/fixtures/render-dynamic-value/modules/x/component/component.js
@@ -14,9 +14,6 @@ export default class extends LightningElement {
     isSymbol = Symbol('yolo');
     isArray = ['foo', 'bar'];
     isObject = { foo: 'bar', baz: 'quux' };
-    isFunction = function whoWouldDoThis() {
-        return 'somebody, probably!';
-    };
     isString = 'ooo eee, ooo ah ah, ting tang, walla walla, bing bang';
     isNumber = 6.02214076e23;
 }
diff --git a/packages/@lwc/ssr-compiler/src/__tests__/utils/expected-failures.ts b/packages/@lwc/ssr-compiler/src/__tests__/utils/expected-failures.ts
@@ -12,7 +12,6 @@ export const expectedFailures = new Set([
     'attribute-global-html/as-component-prop/without-@api/index.js',
     'exports/component-as-default/index.js',
     'known-boolean-attributes/default-def-html-attributes/static-on-component/index.js',
-    'render-dynamic-value/index.js',
     'wire/errors/throws-on-computed-key/index.js',
     'wire/errors/throws-when-colliding-prop-then-method/index.js',
 ]);