Create a ticket to to eclipse.org to integrate the ecj patch

[brianantony456]

We use this bazel-jdt-java-tooclhain and replace the ecj.jar with our latest internal jar. Howver with the change below we get a compile error as expected.

java.lang.IllegalAccessError: class com.google.devtools.build.buildjar.javac.BlazeEcjMain$BlazeEclipseBatchCompiler tried to access private method 'void org.eclipse.jdt.internal.compiler.batch.Main.setSeverity(java.lang.String, int, boolean)' 

Do you think it makes sense to integrate this change to the global ecj.jar ? If so could you be able to create a ticket in eclipse.org to integrate this change and avoid the patch ?

20c1eaa

[guw]

I think it will be difficult to get this accepted by the Eclipse JDT folks. It's needs a lot polishing. It might be easier to get something accepted that is less specific but introduces a more general listener/plug-in concept into ECJ. But I don't have the time currently to work on this.

Would you be interested in adding a PR updating the ECJ version to your needs?

[brianantony456]

Unfortunately, I am not a java deveoper and barely understand the changes. I talked to a member of the eclipse team, they are willing to make the change themselves provided a ticket is created.

Could you please then create a ticket, requesting the following:

• what change is required.
• why & where it is used.

Also could you please let me know once the ticket is ready so that I forward it.

[iloveeclipse]

I think it will be difficult to get this accepted by the Eclipse JDT folks.

I'm a one of ecj folks: please create ticket explaining your needs and PR containing current changes. We can discuss on the PR whether it can be merged "as is" or polish it till it can be merged.

It's needs a lot polishing. It might be easier to get something accepted that is less specific but introduces a more general listener/plug-in concept into ECJ. But I don't have the time currently to work on this.

Me and Simeon could take over with your PR (once you push it :-) ), but we need a ticket with explanation what is actually needed and why, as we are far from understanding all of bazel specialities.

[guw]

Alright. Let's move the discussion then. I described the requirement here.
eclipse-jdt/eclipse.jdt.core#2529

[iloveeclipse]

Patch was just merged upstream, see eclipse-jdt/eclipse.jdt.core#2577