-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Include to the next major release] Remove deprecated functions which are older than 1 year #890
Open
andrews-moc
wants to merge
71
commits into
development
Choose a base branch
from
maintenance/MOB-2889_remove_old_deprecated_interfaces
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Include to the next major release] Remove deprecated functions which are older than 1 year #890
andrews-moc
wants to merge
71
commits into
development
from
maintenance/MOB-2889_remove_old_deprecated_interfaces
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made ChatManager able to resend the failed messages. The ChatAdapter was changed to make the ability to show the failed attachment. The chat repositories were cleaned up. Now they work only with SendMessagePayload. MOB-2590
Hide Logger functionality from public usage, add unit tests for Logger class MOB-2789
MOB-2808, MOB-2809
MOB-2810
… reporting this more than once MOB-2877
Separated audio and video onHold listeners. Now, an audio and a video state are saving separately during onHold. MOB-2909
- Implement logic to show LO opt-in dialog in chat screen - Replace ChatManager's action from PublishSubject to BehaviorProcessor - Remove chat_view.xml unnecessary grouping to prevent a collapsing chain - Implement logic to show LO opt-in dialog in call screen - Minor fix in MessagesNotSeenHandler to avoid counting duplicated messages - Minor fix in AppendNewChatItemUseCase to avoid counting duplicated messages MOB 2665
MOB 2804
andrews-moc
requested review from
Pelkar,
AndriiHorishniiMOC and
gugalo
and removed request for
Pelkar
January 17, 2024 09:53
Pelkar
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Two notes:
- We should create a migration guide for the integrators that can still be using deprecated melthods
- Maybe create a new task for next year to clear the deprecated methods again
DavDo
approved these changes
Jan 17, 2024
gugalo
approved these changes
Jan 17, 2024
AndriiHorishniiMOC
approved these changes
Jan 19, 2024
Created MOB-3003 with a due date 01-15-2025 |
Added the migration guide to PR description. |
andrews-moc
changed the title
Remove deprecated functions which are older than 1 year
[Include to the next major/minor release] Remove deprecated functions which are older than 1 year
Jan 23, 2024
andrews-moc
changed the title
[Include to the next major/minor release] Remove deprecated functions which are older than 1 year
[Include to the next major release] Remove deprecated functions which are older than 1 year
Jan 23, 2024
andrews-moc
force-pushed
the
maintenance/MOB-2889_remove_old_deprecated_interfaces
branch
from
January 24, 2024 08:13
9c51938
to
ccb2cf3
Compare
andrews-moc
force-pushed
the
development
branch
from
January 24, 2024 11:49
3d0b620
to
c73b2b4
Compare
yurii-glia
force-pushed
the
development
branch
4 times, most recently
from
February 8, 2024 10:18
c99b26c
to
07da39a
Compare
andrews-moc
force-pushed
the
development
branch
from
March 21, 2024 12:45
da1545b
to
8235e93
Compare
AndriiHorishniiMOC
force-pushed
the
development
branch
from
May 31, 2024 14:51
adfb797
to
a9baf3c
Compare
I believe that manually removing these functions again would be easier than trying to resolve these conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developers want to remove deprecated functions which are older than 1 year
Release notes:
Remove deprecated functions which are older than 1 year
Migration guide:
GliaWidgets.updateVisitorInfo(VisitorInfoUpdate, Consumer<GliaWidgetException>)
GliaWidgets.updateVisitorInfo(VisitorInfoUpdateRequest, Consumer<GliaException>)
GliaWidgets.getVisitorInfo(Consumer<GliaVisitorInfo>, Consumer<GliaWidgetException>)
GliaWidgets.getVisitorInfo(RequestCallback<VisitorInfo>)
CallActivity.getIntent(Context applicationContext, GliaSdkConfiguration sdkConfiguration, String mediaType)
com.glia.widgets.call.Configuration
containsMediaType
, please useCallActivity.getIntent(Context, Configuration)
CallView.shouldShowMediaEngagementView()
CallView.shouldShowMediaEngagementView(isUpgradeToCall: Boolean)
GliaSdkConfiguration.getContextUrl()
GliaSdkConfiguration.contextAssetId
GliaSdkConfiguration.Builder.contextUrl
GliaSdkConfiguration.Builder.contextAssetId
Additional info: