-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Float style "none" missing #107
Comments
Thanks for suggesting this. I'm currently debating whether introducing this new mode into the colorscheme is reasonable. Outside of a few carefully styled plugins, setting the style of Float groups to the same appearance as Normal is likely to result in broken visuals. For instance, Neovim doesn't default to showing borders on floating windows, so there is no way to visually tell the floating windows apart from normal buffer: I think we should stay away from introducing modes that can only work in combination with modifications of core settings (like forcing borders on all floating windows). IMO all options should work with the editor's defaults, otherwise we would have to provide a detailed explanation of how the editor should be configured to use this or that colorscheme options. Given the granularity of the Neovim API, this is likely to introduce unnecessary confusion and extra documentation work. Question for you: how do other floating windows look for you in this configuration? For example LSP windows displayed using |
Yeah you are right about native windows (without borders) not being distinctive in this case. I might be wrong but looking at Neovim's distros, peoples configurations and popular plugins like Telescope, borders seem to become a bit of a trend. Rather subjective decision I guess, whether it's meant for barebones or more customized setup. Thanks anyways for the time! |
It is true that borders are often applied to popular plugins out of the box by Neovim distributions such as LazyVim, NvChad, etc. And I do think that those borders make the use case you describe viable (even good!). I'm just trying to build a mental picture of what type of plugins may be using |
I have done the following steps before reporting this issue:
Operating system/version
ArchLinux
Terminal emulator/version
Gnome Terminal
$TERM environment variable
xterm-256color
Tmux version
No response
Feature matrix
Minimal vimrc that can reproduce this bug.
not using vim
Steps to reproduce this bug using minimal vimrc
not using vim
Expected behavior
Actual behavior
The text was updated successfully, but these errors were encountered: