Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Break Change] g:gruvbox_material_palette has been splitted into g:gruvbox_material_foreground and g:gruvbox_material_colors_override #130

Open
sainnhe opened this issue May 26, 2022 · 2 comments

Comments

@sainnhe
Copy link
Owner

sainnhe commented May 26, 2022

Why?

The previous design is a bit confusing since the built-in palettes of g:gruvbox_material_palette will only change the foreground colors, while the background colors are controlled by g:gruvbox_material_background.

To make the design more reasonable and match the design of my other color schemes, I decide to split this option.

Sincere apologies for the inconvenience caused.

How to update my vimrc?

If g:gruvbox_material_palette is set to a string, for example 'material', simply replace this option with g:gruvbox_material_foreground.

let g:gruvbox_material_foreground = 'material'

If g:gruvbox_material_palette is set to a dictionary, replace it with g:gruvbox_material_colors_override

let g:gruvbox_material_colors_override = {'bg0': ['#1d2021', '234'], 'bg2': ['#282828', '235']}
@sainnhe sainnhe pinned this issue May 26, 2022
sainnhe added a commit that referenced this issue May 26, 2022
- Why?

The previous design is a bit confusing since the built-in palettes of `g:gruvbox_material_palette` will only change the foreground colors, while the background colors are controlled by `g:gruvbox_material_background`.

To make the design more reasonable and match the design of my other color schemes, I decide to split this option.

Sincere apologies for the inconvenience caused.

- How to update my vimrc?

If `g:gruvbox_material_palette` is set to a string, for example `'material'`, simply replace this option with `g:gruvbox_material_foreground`.

```vim
let g:gruvbox_material_foreground = 'material'
```

If `g:gruvbox_material_palette` is set to a dictionary, replace it with `g:gruvbox_material_colors_override`

```vim
let g:gruvbox_material_colors_override = {'bg0': ['#1d2021', '234'], 'bg2': ['#282828', '235']}
```

Ref: #130
@Frederick888
Copy link

It seems users who have g:gruvbox_material_better_performance on will need to manually clean up after/ directory.

@sainnhe
Copy link
Owner Author

sainnhe commented May 26, 2022

It seems users who have g:gruvbox_material_better_performance on will need to manually clean up after/ directory.

after/syntax should be regenerated automatically, but after/plugin need to be manually cleaned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants