Skip to content

Commit 8cf36a3

Browse files
committed
fix conflicts
1 parent 5eebe1e commit 8cf36a3

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

dotnet.go

+4-1
Original file line numberDiff line numberDiff line change
@@ -724,11 +724,14 @@ func (pe *File) parseCLRHeaderDirectory(rva, size uint32) error {
724724
table.Content, n, err = pe.parseMetadataMethodSpecTable(offset)
725725
case GenericParamConstraint: // 0x2c
726726
table.Content, n, err = pe.parseMetadataGenericParamConstraintTable(offset)
727-
728727
default:
729728
pe.logger.Warnf("unhandled metadata table %d %s offset 0x%x cols %d",
730729
tableIndex, MetadataTableIndexToString(tableIndex), offset, table.CountCols)
731730
}
731+
if err != nil {
732+
pe.logger.Warnf("parsing metadata table %s failed with %v",
733+
MetadataTableIndexToString(tableIndex), err)
734+
}
732735
offset += n
733736

734737
}

dotnet_metadata_tables.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -1195,7 +1195,7 @@ type AssemblyRefProcessorTableRow struct {
11951195

11961196
// AssemblyRefOS 0x25
11971197
type AssemblyRefOSTableRow struct {
1198-
OSPlatformId uint32 `json:"os_platform_id"` // a 4-byte constant
1198+
OSPlatformID uint32 `json:"os_platform_id"` // a 4-byte constant
11991199
OSMajorVersion uint32 `json:"os_major_version"` // a 4-byte constant
12001200
OSMinorVersion uint32 `json:"os_minor_version"` // a 4-byte constan)
12011201
AssemblyRef uint32 `json:"assembly_ref"` // an index into the AssemblyRef table

security.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -565,12 +565,12 @@ func parseAuthenticodeContent(content []byte) (AuthenticodeContent, error) {
565565
if err != nil {
566566
return AuthenticodeContent{}, err
567567
}
568-
hashFunction, algorithmId, err := parseHashAlgorithm(authenticodeContent.MessageDigest.DigestAlgorithm)
568+
hashFunction, algorithmID, err := parseHashAlgorithm(authenticodeContent.MessageDigest.DigestAlgorithm)
569569
if err != nil {
570570
return AuthenticodeContent{}, err
571571
}
572572
return AuthenticodeContent{
573-
Algorithm: algorithmId,
573+
Algorithm: algorithmID,
574574
HashFunction: hashFunction,
575575
HashResult: authenticodeContent.MessageDigest.Digest,
576576
}, nil

version.go

-2
Original file line numberDiff line numberDiff line change
@@ -372,9 +372,7 @@ func (pe *File) parseVersionEntry(e ResourceDirectoryEntry, vers map[string]stri
372372
}
373373
}
374374
case VarFileInfoString:
375-
break
376375
default:
377-
break
378376
}
379377

380378
offset += uint32(f.Length)

0 commit comments

Comments
 (0)