-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Swaps): deprecate executedSurplusFee
#4763
Draft
iamacook
wants to merge
3
commits into
dev
Choose a base branch
from
deprecate-executed-surplus-fee
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview❌ Deploy failed! |
Coverage (56%)
|
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🟡 | Statements | 74.28% (-0% 🔻) |
14762/19874 |
🔴 | Branches | 52.02% (-0.01% 🔻) |
3534/6793 |
🔴 | Functions | 57.38% | 2096/3653 |
🟡 | Lines | 75.82% (-0% 🔻) |
13395/17667 |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
---|---|---|---|---|---|
🟡 | ... / index.tsx |
72.73% (-4.55% 🔻) |
75% (-25% 🔻) |
60% | 71.43% (-4.76% 🔻) |
Test suite run success
1793 tests passing in 242 suites.
Report generated by 🧪jest coverage report action from c5751f6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/packages/store/scripts/api-schema
/packages/store/src/gateway/AUTO_GENERATED
What it solves
Deprecation of
executedSurplusFee
, addingexecutedFee
andexecutedFeeToken
How this PR fixes it
This moves from referencing
executedSurplusFee
toexecutedFee
and rendering the fee token fromexecutedFeeToken
.Note: associated mock data and store generation has also been updated.
How to test it
Observe no error/difference when opening the confirmation view/transaction details of a swap/TWAP.
Checklist