Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.49.0 #4746

Merged
merged 106 commits into from
Jan 13, 2025
Merged

Release 1.49.0 #4746

merged 106 commits into from
Jan 13, 2025

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Jan 8, 2025

Features

Other

  • Switch to Yarn 4
  • Move to a monorepo with the new mobile app
  • Bug fixes

compojoom and others added 30 commits December 18, 2024 11:14
* refactor: switch to use yarn v4
fix: github action crashing
fix: failing yarn v4 install due to incorrect 3rd party dependency
fix: remove Keystone pckg causing yarn v4 failure
fix: resolutions
fix: failing tests
fix: github acitons not working with new yarn v4
fix: update readme

Update .github/actions/cache-deps/action.yml

Co-authored-by: Usame Algan <[email protected]>

---------

Co-authored-by: Usame Algan <[email protected]>
Bumps [@walletconnect/utils](https://github.com/walletconnect/walletconnect-monorepo) from 2.17.2 to 2.17.3.
- [Release notes](https://github.com/walletconnect/walletconnect-monorepo/releases)
- [Commits](WalletConnect/walletconnect-monorepo@2.17.2...2.17.3)

---
updated-dependencies:
- dependency-name: "@walletconnect/utils"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@cowprotocol/app-data](https://github.com/cowprotocol/app-data) from 2.1.0 to 2.4.0.
- [Release notes](https://github.com/cowprotocol/app-data/releases)
- [Commits](cowprotocol/app-data@v2.1.0...v2.4.0)

---
updated-dependencies:
- dependency-name: "@cowprotocol/app-data"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@reduxjs/toolkit](https://github.com/reduxjs/redux-toolkit) from 2.2.6 to 2.5.0.
- [Release notes](https://github.com/reduxjs/redux-toolkit/releases)
- [Commits](reduxjs/redux-toolkit@v2.2.6...v2.5.0)

---
updated-dependencies:
- dependency-name: "@reduxjs/toolkit"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@ducanh2912/next-pwa](https://github.com/DuCanhGH/next-pwa) from 9.7.1 to 10.2.9.
- [Release notes](https://github.com/DuCanhGH/next-pwa/releases)
- [Changelog](https://github.com/DuCanhGH/next-pwa/blob/master/CHANGELOG.md)
- [Commits](https://github.com/DuCanhGH/next-pwa/compare/@ducanh2912/[email protected]...@ducanh2912/[email protected])

---
updated-dependencies:
- dependency-name: "@ducanh2912/next-pwa"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
With the change to yarn v4 we need to slightly adjust the Dockerfile
* refactor: Split up MyAccounts component

* refactor: Move allSafes computation and sort comparator into AccountsList

* fix: Add tests for AccountsList

* fix: Add tests for PinnedSafes

* fix: Add tests for FilteredSafes, adjust maybePlural to account for 0 value

* fix: Failing maybePlural test

* fix: Change QueueActions to a button instead of an a element

* fix: Remove watchlist tracking and use pinned safes tracking instead

* refactor: Rename AccountsFilter to AccountListFilters
* Chore: fine-tune AI review prompt

* Update code-review-gpt.yml
* fix: React props errors

* chore: Update snapshots

* fix: Use NextLink inside Tab component instead of wrapping
* Refactor: message origin instead of safeAppId

* Beta 1

* Yarn lock
* feat: add url params for safe and signer address to typeform link

* feat: update styles for outreach banner and pass addresses as url params to survey

* feat: target all safes

* fix: popup flickers when survey has already been completed

* compress avatar image
* fix: don't use `chainId` when calculating domain hash of <=1.2.0

* Extract check to variable

* fix: use `dataGas` when calculating message hash of <1.0.0
* fix: don't use `chainId` when calculating domain hash of <=1.2.0

* Extract check to variable

* fix: use `dataGas` when calculating message hash of <1.0.0

* feat: display `SafeMessage` message hash when signing off-chain
* Fix: rm circular dependency

* Rm GPT bot
* refactor: use jest for tests

I couldn’t find a way to fix our tests and make them work with tamagui.
Vitest is ignoring the native.ts files that tamagui has and tests were
failing, because of that I reconfigured the project to use jest.

* fix: button test

* feat: add container tests

* feat: add DataRow tests
* feat: create tx-history list components

* feat: use the new cards components in the TxHistory list

* fix: remove todo

* feat: add missing variants to tx history page

* feat: add missing multiSendCall information in the txList

* feat: create static transactions messages layout

* fix: android crash

* feat: add detox test for transactions

* fix: add the right name in the bulk transactions section

* fix: scroll margin in the txHistory component

* fix: story book of the TxCards components

* fix: unit tests

* fix: detox tests

* fix: remove unnecessary comment

* fix: remove swap order comment

* fix: tx history in light mode

* fix: use snapshot tests instead of inline object comparison

* fix: remove TODO comments

* chore: rename tx cards

---------

Co-authored-by: Daniel Dimitrov <[email protected]>
* chore: use Alert component for the status banners

* chore: use GestureHandler on the application entry point

* fix: remove 'isStorybookEnv' log

* fix: rename tests cases
* chore: adjust api gateway folder structure

* feat: create chains slice

* feat: create activeChain slice

* chore: remove TODO comment

* chore: remove unused code

* feat: use activeChain information instead of hard coded data

* fix: remove performance optmization in pro of readability
* feat: create pending tx screen

* feat: add pending transactions static layout in the home screen

* feat: add pending transactions slice in the api gateway

* feat: add new variant in the Alert component

* feat: create CircularBadge component to use it as the circular icon with text

* feat: put groupTx to respect SOLID definition

* feat: add lodash as project dependency

* feat: add missing parameters in the TxCards components

* feat: adjust reusable components layout

* feat: create pending transactions screen

* feat: generated snapshots
ThatOneCalculator and others added 14 commits January 3, 2025 11:43
* feat: monochrome launcher icon for Android

* replace monochrome icon with even further minified version
* feat: install necessary packages for sortable functionallity

* chore: move active chain information to be under activeSafe to avoid duplicated source of truth and better and domain centralization

* feat: allow safeList consumer to remove the horizontal padding if he/she/they wants

* feat: add edit accounts functionality

* fix: unit tests

* fix: improve seperation of concern between sortable and edit/remove accounts

* fix: improve code readability

* fix: generated yarn.lock

* feat: cover Assets feature with unit tests

* chore: improve test reliability

* fix: remove inline style

* fix: use selectors and dispatch from useApp hooks

* fix: lint

* feat: cover NFTs container

* chore: cover my accounts functionality with unit tests

* fix: AccountItem lint
* Fix: sandbox coingecko icons

* Rm crossorigin
* feat: change safe search placeholder text

* update wording from design feedback
Bumps [@mui/x-date-pickers](https://github.com/mui/mui-x/tree/HEAD/packages/x-date-pickers) from 7.23.2 to 7.23.3.
- [Release notes](https://github.com/mui/mui-x/releases)
- [Changelog](https://github.com/mui/mui-x/blob/v7.23.3/CHANGELOG.md)
- [Commits](https://github.com/mui/mui-x/commits/v7.23.3/packages/x-date-pickers)

---
updated-dependencies:
- dependency-name: "@mui/x-date-pickers"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@react-navigation/material-top-tabs](https://github.com/react-navigation/react-navigation/tree/HEAD/packages/material-top-tabs) from 7.0.18 to 7.1.0.
- [Release notes](https://github.com/react-navigation/react-navigation/releases)
- [Changelog](https://github.com/react-navigation/react-navigation/blob/main/packages/material-top-tabs/CHANGELOG.md)
- [Commits](https://github.com/react-navigation/react-navigation/commits/@react-navigation/[email protected]/packages/material-top-tabs)

---
updated-dependencies:
- dependency-name: "@react-navigation/material-top-tabs"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@storybook/addon-ondevice-actions](https://github.com/storybookjs/react-native) from 8.4.2 to 8.4.4.
- [Release notes](https://github.com/storybookjs/react-native/releases)
- [Changelog](https://github.com/storybookjs/react-native/blob/next/CHANGELOG.md)
- [Commits](storybookjs/react-native@v8.4.2...v8.4.4)

---
updated-dependencies:
- dependency-name: "@storybook/addon-ondevice-actions"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ner (#4739)

* fix: dismiss outreach banner in batch_tx e2e tests

* fix: close outreach popup whenever a signer is connected

* remove duplicate check for outreach popup
Copy link

github-actions bot commented Jan 8, 2025

Copy link

github-actions bot commented Jan 8, 2025

Coverage (56%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files55.5649.8149.6556.04 
src0000 
   react-app-env.d.ts0000 
src/components/Alert10091.66100100 
   Alert.tsx10091.6610010055
   index.ts0000 
src/components/Badge87.587.510087.5 
   Badge.tsx85.7187.510085.7149
   index.ts0000 
   theme.ts100100100100 
src/components/BlurredIdenticonBackground0000 
   BlurredIdenticonBackground.tsx000014–51
   index.tsx0000 
src/components/ChainsDisplay10084.61100100 
   ChainsDisplay.tsx10084.6110010015–18
   index.ts0000 
src/components/Container10075100100 
   Container.tsx1007510010032
   index.ts0000 
src/components/CopyButton010000 
   CopyButton.tsx0100005–10
   index.ts0000 
src/components/DataRow100100100100 
   DataRow.tsx100100100100 
   index.ts0000 
src/components/Dropdown88.46607088 
   Dropdown.tsx81.256057.1481.2555, 63, 128
   index.ts0000 
   sheetComponents.tsx100100100100 
src/components/EthAddress0000 
   ETHAddress.tsx000011–12
   index.ts0000 
src/components/Fiat100100100100 
   Fiat.tsx100100100100 
   index.ts0000 
src/components/Identicon100100100100 
   Identicon.tsx100100100100 
   index.ts0000 
src/components/InnerShadow100100100100 
   InnerShadow.tsx100100100100 
   index.ts0000 
src/components/Logo100100100100 
   Logo.tsx100100100100 
   index.ts0000 
src/components/SafeButton100100100100 
   SafeButton.tsx100100100100 
   index.ts0000 
src/components/SafeFontIcon87.585.7110087.5 
   SafeFontIcon.tsx87.585.7110087.528
   index.ts0000 
src/components/SafeListItem10066.66100100 
   SafeListItem.tsx10066.6610010074–88
   index.tsx0000 
src/components/SafeTab250026.31 
   SafeTab.tsx44.44100044.4413–25
   SafeTabBar.tsx9.09001018–38
   index.tsx0000 
   types.ts0000 
src/components/StatusBanners/PendingTransactions10050100100 
   PendingTransactions.tsx1005010010017
   index.tsx0000 
src/components/Tab0000 
   TabNameContext.tsx00003–10
src/components/Title100100100100 
   LargeHeaderTitle.tsx100100100100 
   NavBarTitle.tsx100100100100 
   index.ts0000 
src/components/TxInfo23.84.545023.8 
   TxInfo.tsx23.84.545023.845–96, 100
   index.tsx0000 
src/components/navigation100100100100 
   TabBarIcon.tsx100100100100 
   index.ts0000 
src/components/transactions-list/Card/AccountCard10075100100 
   AccountCard.tsx1007510010052
   index.ts0000 
src/components/transactions-list/Card/AssetsCard100100100100 
   AssetsCard.tsx100100100100 
   index.tsx0000 
src/components/transactions-list/Card/TxBatchCard100100100100 
   TxBatchCard.tsx100100100100 
   index.tsx0000 
src/components/transactions-list/Card/TxConflictingCard010000 
   TxConflictingCard.tsx01000013–31
   index.tsx0000 
src/components/transactions-list/Card/TxContractInteractionCard100100100100 
   TxContractInteractionCard.tsx100100100100 
   index.tsx0000 
src/components/transactions-list/Card/TxCreationCard100100100100 
   TxCreationCard.tsx100100100100 
   index.ts0000 
src/components/transactions-list/Card/TxGroupedCard90.9757590.9 
   TxGroupedCard.tsx90.9757590.957
   index.tsx0000 
src/components/transactions-list/Card/TxRejectionCard100100100100 
   TxRejectionCard.tsx100100100100 
   index.tsx0000 
src/components/transactions-list/Card/TxSafeAppCard100100100100 
   TxSafeAppCard.tsx100100100100 
   index.tsx0000 
src/components/transactions-list/Card/TxSettingsCard10050100100 
   TxSettingsCard.tsx1005010010017
   index.tsx0000 
src/components/transactions-list/Card/TxSwapCard100100100100 
   TxSwapCard.tsx100100100100 
   index.tsx0000 
src/components/transactions-list/Card/TxTokenCard88.8880.5510088.88 
   TxTokenCard.tsx88.8880.5510088.8840, 70
   index.tsx0000 
src/config44.4483.33044.44 
   constants.ts10083.3310010015
   ethers.ts01000010–38
src/features/Assets010000 
   Assets.container.tsx0100009–21
   index.tsx0000 
   styles.ts010010003
src/features/Assets/components/AccountItem91.6668.7510090.9 
   AccountItem.tsx91.6668.7510090.924
   index.ts0000 
src/features/Assets/components/AccountItem/hooks5002553.84 
   useEditAccountItem.ts5002553.8415–29
src/features/Assets/components/AssetsHeader0000 
   AssetsHeader.container.tsx0100006–13
   AssetsHeader.tsx000015
   index.tsx0000 
   styles.ts010010003
src/features/Assets/components/Balance0000 
   Balance.container.tsx01000014–36
   Balance.tsx000025–42
   ChainItems.tsx000017–28
   index.tsx0000 
src/features/Assets/components/Fallback10075100100 
   Fallback.tsx1007510010012
   index.ts0000 
src/features/Assets/components/MyAccounts88.2310066.66100 
   MyAccounts.container.tsx100100100100 
   MyAccountsFooter.tsx71.4210033.33100 
   index.ts0000 
src/features/Assets/components/MyAccounts/hooks43.7533.335044.82 
   useMyAccountsService.ts100100100100 
   useMyAccountsSortable.ts000012–38
src/features/Assets/components/NFTs10081.81100100 
   NFTItem.tsx100501001008
   NFTs.container.tsx10088.8810010026
   index.tsx0000 
src/features/Assets/components/Navbar0000 
   Navbar.tsx000018–66
   index.tsx0000 
src/features/Assets/components/NoFunds100100100100 
   EmptyToken.tsx100100100100 
   NoFunds.tsx100100100100 
   index.ts0000 
src/features/Assets/components/Tokens100100100100 
   Tokens.container.tsx100100100100 
   index.tsx0000 
src/features/Notifications010000 
   Notifications.container.tsx0100004–5
   index.tsx0000 
src/features/Onboarding100100100100 
   Onboarding.container.tsx100100100100 
   index.ts0000 
src/features/Onboarding/components/OnboardingCarousel9510087.595 
   CarouselFeedback.tsx100100100100 
   CarouselItem.tsx100100100100 
   OnboardingCarousel.tsx83.331008083.3318
   index.ts0000 
   items.tsx100100100100 
src/features/Onboarding/components/OnboardingHeader100100100100 
   OnboardingHeader.tsx100100100100 
   index.ts0000 
src/features/Onboarding/components/ParticlesLogo100100100100 
   ParticlesLogo.tsx100100100100 
   index.ts0000 
src/features/PendingTx0000 
   PendingTx.container.tsx0100006–8
   index.tsx0000 
   utils.tsx000021–133
src/features/PendingTx/components/PendingTxList0000 
   PendingTxList.container.tsx000033–63
   index.ts0000 
src/features/Settings0000 
   Settings.container.tsx00007–14
   Settings.tsx000020–137
   index.tsx0000 
src/features/Settings/components/AppSettings010000 
   AppSettings.container.tsx0100007–20
   AppSettings.tsx01000010–11
   index.ts0000 
src/features/Settings/components/IdenticonWithBadge10050100100 
   IdenticonWithBadge.tsx1005010010021–22
   index.ts0000 
src/features/Settings/components/Navbar0000 
   Navbar.tsx01000010–27
   SettingsButton.tsx0100006–15
   SettingsMenu.tsx000017–81
   index.ts0000 
src/features/Signers010000 
   Signers.container.tsx0100003–4
   index.tsx0000 
src/features/TxHistory0000 
   TxHistory.container.tsx000011–37
   index.tsx0000 
   utils.tsx000018–58
src/features/TxHistory/components/TxHistoryList0000 
   TxHistoryList.tsx000018–32
   index.ts0000 
src/hooks/useCopyAndDispatchToast100100100100 
   index.ts100100100100 
src/hooks/useInfiniteScroll75508073.33 
   index.ts0000 
   useInfiniteScroll.ts75508073.3330–35
src/hooks/usePendingTxs0000 
   index.ts000015–40
src/hooks/useSign805010080 
   index.ts0000 
   useSign.ts80501008034, 43, 55, 62, 67
src/hooks/useTransactionType91.6679.1610091.66 
   index.tsx91.6679.1610091.66116–124
src/navigation0000 
   useScrollableHeader.tsx000022–47
src/services/exceptions88.8810010088.88 
   utils.ts88.8810010088.8814
src/store66.665040.966.66 
   activeSafeSlice.ts751005071.4219–22
   constants.ts100100100100 
   index.ts91.665010091.6644
   myAccountsSlice.ts83.33100508013
   safesSlice.ts37.510012.538.4638–48, 57–58
   storage.ts251000258–17
   txHistorySlice.ts100100100100 
src/store/chains68.421004075 
   index.ts68.42100407517, 30–33
src/store/hooks100100100100 
   index.ts100100100100 
src/theme100100100100 
   navigation.ts100100100100 
   tamagui.config.ts100100100100 
   tokens.ts100100100100 
src/theme/helpers10081.81100100 
   utils.ts10081.8110010037, 41
src/theme/palettes100100100100 
   darkPalette.ts100100100100 
   lightPalette.ts100100100100 
src/theme/provider59.0927.776059.09 
   font.tsx90501009034
   safeTheme.tsx10037.510010019–34
   toastProvider.tsx000010–29
src/utils75.6547.9172.0975.7 
   date.ts9666.6685.7110031, 35–39
   formatters.ts908010088.889
   gateway.ts100100100100 
   transaction-guards.ts79.24606880.7650–56, 66, 98, 102, 116, 120
   transactions.tsx00004–29

katspaugh and others added 2 commits January 8, 2025 11:57
* Fix: remove network selector from WC proposal warning

* Clean up event
@liliya-soroka
Copy link
Member

  1. Blocker:
    add network doesn't work on the release +prod CGW for the same safe
    safe = sep:0xE21132D4474f5bacf8ab460cfADA876e17A8b86e
    owner = sep:0x65F8236309e5A99Ff0d129d04E486EBCE20DC7B0
    https://github.com/user-attachments/assets/3f12d611-13a0-4644-9a2e-f9f6909ccbc0

@liliya-soroka
Copy link
Member

  1. Blocker: A new created safe on Optimism has 1.3.0+L2 mastercopy instead of 1.4.1
    Release +Prod CGW

@katspaugh
Copy link
Member Author

Fixed both here: #4747

@liliya-soroka
Copy link
Member

verified

@katspaugh katspaugh merged commit 2ae2626 into main Jan 13, 2025
9 of 13 checks passed
@katspaugh katspaugh deleted the release branch January 13, 2025 12:26
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.