Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(redesign): form builder redesign #828

Merged
merged 10 commits into from
Oct 22, 2024
Merged

feat(redesign): form builder redesign #828

merged 10 commits into from
Oct 22, 2024

Conversation

clovisdasilvaneto
Copy link
Contributor

@clovisdasilvaneto clovisdasilvaneto commented Oct 18, 2024 •
edited
Loading

This PR address the design reviews in the Design QA document.

What it solves

Resolves #824

How to test it

  • open the Design QA document
  • open the transaction builder
  • All the requested changes should be done, except the margin of the form title and inputs.

Screenshots

Screenshot 2024-10-18 at 10 11 14 Screenshot 2024-10-18 at 10 11 22

@github-actions GitHub Actions
Copy link

@clovisdasilvaneto clovisdasilvaneto self-assigned this Oct 18, 2024
@clovisdasilvaneto
Copy link
Contributor Author

clovisdasilvaneto commented Oct 18, 2024 •
edited
Loading

Design Review by Lila: ✅

@liliya-soroka
Copy link
Member

  1. the tooltip text is hardly seen
image image 2. when the file contains menu actions: New design image

Old design
image

  1. Missed info block when the list of actions is long
image Old image

@liliya-soroka
Copy link
Member

Verified

@clovisdasilvaneto clovisdasilvaneto merged commit 3631f4f into development Oct 22, 2024
6 of 7 checks passed
@clovisdasilvaneto clovisdasilvaneto deleted the feat/form-builder-redesign branch October 22, 2024 10:20
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@usame-algan usame-algan usame-algan approved these changes

Assignees

@clovisdasilvaneto clovisdasilvaneto

Labels
None yet
Projects
Safe{Wallet}
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add safe wallet dark mode support in the transaction builder
3 participants
@clovisdasilvaneto @liliya-soroka @usame-algan