-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WalletConnect] Send dapp's origin in the request #702
Comments
katspaugh
changed the title
[WalletConnect] Use dapp's origin instead of WalletConnect's own host as "origin"
[WalletConnect] Send dapp's origin in the request
May 23, 2023
@mmv08's feedback:
|
Since adding a completely new field is a lot of work across frontend, SDK and backend, and it's only needed for the WalletConnect app, perhaps adding the dapp's host as a query param to the existing |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the WalletConnect app sends its host as the origin string. This makes the tx-service display a nice icon and the app's name in the history, but it's not very useful. Basically all non-Safe App transactions are either WalletConnect, or from the safe mobile apps, or direct contract interactions.
It would be more useful to send the connected dapp's origin instead. Or in addition to the WC origin to keep the app usage analytics intact.
E.g. if you're connected to OpenSea, send opensea.io as the dapp origin. This will allow us to add domain-based security checks on the Safe wallet side.
The text was updated successfully, but these errors were encountered: