-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(gas-station): design fixes #409
Conversation
Branch preview✅ Deployed successfully in branch deployment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8815aa0
to
164cb1e
Compare
I've allowed the background blobs to overlap the slider giving it a really nice and smooth effect. Also added a gradient to the right side of the video.
I would prefer to not apply this suggestion and stick with the Figma design |
There is still the issue that the video ends "abruptly" and carousel doesn't span the entire width. The designs depict them spanning the entire page. cc @TanyaEfremova |
The page content is limited to
What could be a elegant way to handle it? |
You could blur to both sides of the video/carousel but maybe @TanyaEfremova has a better idea. |
I've added gradients on both sides and I think it looks much better now! Thanks for making a point. I will ping Tanya to give her opinion |
I like the suggestion, and I think, we should proceed with that, however, on the link above I cannot see the gradient within the ribbons. |
Addresses the following style fixes: