Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(gas-station): design fixes #409

Merged
merged 10 commits into from
Jul 8, 2024
Merged

Conversation

DiogoSoaress
Copy link
Member

@DiogoSoaress DiogoSoaress commented Jul 7, 2024

Addresses the following style fixes:

  • Center text block in Hero section
  • Smooth the edges of the video + slider
  • Have the Slider occupy the container full width
  • Between sections spacing

Copy link

github-actions bot commented Jul 7, 2024

Branch preview

✅ Deployed successfully in branch deployment:

https://gas_station_design_fixes--homepage.review.5afe.dev

@DiogoSoaress DiogoSoaress requested a review from iamacook July 7, 2024 21:40
Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good but two things I noticed on the deployment:

The video and carousel "end" abruptly. Can they transition into the background instead?

image


The doc-related cards stack. I think they should either span the entire width of the container, or be positioned horizontally:

image

@DiogoSoaress DiogoSoaress force-pushed the gas-station-design-fixes branch from 8815aa0 to 164cb1e Compare July 8, 2024 09:13
@DiogoSoaress
Copy link
Member Author

The video and carousel "end" abruptly. Can they transition into the background instead?

I've allowed the background blobs to overlap the slider giving it a really nice and smooth effect. Also added a gradient to the right side of the video.

The doc-related cards stack. I think they should either span the entire width of the container, or be positioned horizontally

I would prefer to not apply this suggestion and stick with the Figma design

@DiogoSoaress DiogoSoaress requested a review from iamacook July 8, 2024 09:23
@iamacook
Copy link
Member

iamacook commented Jul 8, 2024

I've allowed the background blobs to overlap the slider giving it a really nice and smooth effect. Also added a gradient to the right side of the video.

There is still the issue that the video ends "abruptly" and carousel doesn't span the entire width. The designs depict them spanning the entire page. cc @TanyaEfremova

image

image

@DiogoSoaress
Copy link
Member Author

The page content is limited to max-width: 1630px; because of

which impacts the video and the carrousel, so the video will need to be cut in larger viewports eventually.

What could be a elegant way to handle it?

@iamacook
Copy link
Member

iamacook commented Jul 8, 2024

What could be a elegant way to handle it?

You could blur to both sides of the video/carousel but maybe @TanyaEfremova has a better idea.

@DiogoSoaress
Copy link
Member Author

I've added gradients on both sides and I think it looks much better now! Thanks for making a point. I will ping Tanya to give her opinion

@TanyaEfremova
Copy link
Contributor

I like the suggestion, and I think, we should proceed with that, however, on the link above I cannot see the gradient within the ribbons.
Possible to make something like this? I replicated it in design. If we can use a different color for the gradient, like in the video itself #030D02, it would look even better and more "natural".

@DiogoSoaress
Copy link
Member Author

Can you include this blob in the design? I think that's what emphasized so much the edges of the video + slider container. I suggest we move it to a new issue as an improvement

Screenshot 2024-07-08 at 13 06 29

@DiogoSoaress DiogoSoaress merged commit 7b50461 into main Jul 8, 2024
4 checks passed
@DiogoSoaress DiogoSoaress deleted the gas-station-design-fixes branch July 8, 2024 11:09
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants