Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proxy implementation address to Contract Metadata #1506

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Add proxy implementation address to Contract Metadata #1506

merged 1 commit into from
Jan 3, 2025

Conversation

falvaradorodriguez
Copy link
Contributor

@coveralls
Copy link

coveralls commented Jan 2, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12596056482

Details

  • 11 of 13 (84.62%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.01%) to 93.904%
Changes Missing Coverage Covered Lines Changed/Added Lines %
safe_eth/eth/tests/clients/test_etherscan_client_v2.py 8 10 80.0%
Files with Coverage Reduction New Missed Lines %
safe_eth/eth/tests/clients/test_etherscan_client_v2.py 1 86.76%
safe_eth/eth/clients/etherscan_client.py 1 86.96%
safe_eth/eth/tests/clients/test_etherscan_client.py 1 90.91%
Totals Coverage Status
Change from base Build 12595534036: -0.01%
Covered Lines: 9443
Relevant Lines: 10056
💛 - Coveralls

@falvaradorodriguez falvaradorodriguez marked this pull request as ready for review January 2, 2025 14:29
@falvaradorodriguez falvaradorodriguez requested a review from a team as a code owner January 2, 2025 14:29
@falvaradorodriguez falvaradorodriguez force-pushed the add-proxy-implementation-address-contract-metadata branch from eefcfe2 to 9f22e9b Compare January 3, 2025 10:07
@moisses89
Copy link
Member

Awesome! :)

@moisses89 moisses89 mentioned this pull request Jan 3, 2025
Open
@falvaradorodriguez falvaradorodriguez merged commit 96138dd into main Jan 3, 2025
6 checks passed
@falvaradorodriguez falvaradorodriguez deleted the add-proxy-implementation-address-contract-metadata branch January 3, 2025 11:44
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moisses89 moisses89 moisses89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@falvaradorodriguez @coveralls @moisses89