Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase coverage to at least 80% #271

Closed
Uxio0 opened this issue Oct 3, 2023 · 1 comment · Fixed by #279
Closed

Increase coverage to at least 80% #271

Uxio0 opened this issue Oct 3, 2023 · 1 comment · Fixed by #279
Assignees
@Uxio0
Labels
enhancement New feature or request

Comments

@Uxio0
Copy link
Member

Uxio0 commented Oct 3, 2023

What is needed?

Testing quality should be improved, currently for some operations only the happy path is tested.
@Uxio0 Uxio0 added the enhancement New feature or request label Oct 3, 2023
@Uxio0 Uxio0 self-assigned this Oct 3, 2023
This was referenced Oct 11, 2023
Closed
Merged
@Uxio0 Uxio0 changed the title Increase coverage to at least 90% Increase coverage to at least 80% Oct 17, 2023
@Uxio0
Copy link
Member Author

Uxio0 commented Oct 18, 2023 •
edited
Loading

Getting coverage to 90% in a CLI project it's very difficult. A lot of lines are for parsing and validating input, and I think mocking all that is not time well spent. We tried to increase coverage in the most important parts of the Safe CLI (Safe Operator, Safe Tx Service Operator, Safe Creator...) and decided that 80% is a good number for coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Uxio0 Uxio0

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increase coverage safe-global/safe-cli
Increase coverage safe-global/safe-cli
1 participant
@Uxio0