Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running the CI Deep template via cron job fails #970

Closed
PaulRBerg opened this issue Jul 15, 2024 · 8 comments
Closed

Running the CI Deep template via cron job fails #970

PaulRBerg opened this issue Jul 15, 2024 · 8 comments
Assignees
Labels
priority: 2 We will do our best to deal with this. type: test Adding, updating, or removing tests. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.

Comments

@PaulRBerg
Copy link
Member

@PaulRBerg PaulRBerg added priority: 2 We will do our best to deal with this. type: test Adding, updating, or removing tests. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise. labels Jul 15, 2024
@smol-ninja
Copy link
Member

Thanks for noticing. I will look into it. Do you receive the failed CI results on your email? Is there a way to forward them to [email protected] so that I can also receive them?

@PaulRBerg
Copy link
Member Author

You're welcome.

I'd prefer not to send these updates to the [email protected] email address to avoid spamming the frontend team with Solidity CI failures.

I shared a pro tip on Slack about how to set up email notifications for failed CI runs.

@smol-ninja
Copy link
Member

Raised an issue with the Github team: actions/runner#3394

@PaulRBerg
Copy link
Member Author

Thanks @smol-ninja. We might also want to reach out via GitHub Support; we're paying customers after all.

@smol-ninja
Copy link
Member

Good idea. I have created a ticket with them.

@smol-ninja
Copy link
Member

a34e528 and sablier-labs/v2-periphery@2d338a7 should fix it now. The possible issue was that fromJSON requires if and else condition inside it.

So instead of fromJSON(inputs.integrationFuzzRuns) || 100000 it should have been fromJSON(inputs.integrationFuzzRuns || '100000').

@PaulRBerg
Copy link
Member Author

Great! Let's see if it works next Sunday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: 2 We will do our best to deal with this. type: test Adding, updating, or removing tests. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.
Projects
None yet
Development

No branches or pull requests

2 participants