Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Error alerts have a css typo #3427

Open
NFuller721 opened this issue Jan 28, 2025 · 6 comments
Open

docs: Error alerts have a css typo #3427

NFuller721 opened this issue Jan 28, 2025 · 6 comments
Labels

Comments

@NFuller721
Copy link

On which page do you see this issue?

https://v5.daisyui.com/components/alert/

Describe the issue

Hey, I just noticed that in "Alert soft/outline/dash style" the error alert has a typo for "alert error ..." instead of "alert alert-error ...". Just wanted to throw it out there, also v5 looks amazing and thank you!

What browsers are you seeing the problem on?

Chrome

Copy link

Thank you @NFuller721 for reporting issues. It helps daisyUI a lot 💚
I'll be working on issues one by one. I will help with this one as soon as a I find a solution.
In the meantime providing more details and reproduction links would be helpful.

@saadeghi
Copy link
Owner

I don't see the typo. Can you attach a screenshot please?

@NFuller721
Copy link
Author

Image

I forgot to mention that the typo was on v5, sorry

@saadeghi
Copy link
Owner

I still don't see the typo 👀
Are you mentioning the title "Alert dash style", etc? because that's not the class name. That's title of code example and shouldn't be alert-dash.

@NFuller721
Copy link
Author

<div role="alert" class="alert alert-info alert-outline">
  <span>12 unread messages. Tap to see.</span>
</div>
<div role="alert" class="alert alert-success alert-outline">
  <span>Your purchase has been confirmed!</span>
</div>
<div role="alert" class="alert alert-warning alert-outline">
  <span>Warning: Invalid email address!</span>
</div>
<!------->
<div role="alert" class="alert [error -> alert-error] alert-outline">
  <span>Error! Task failed successfully.</span>
</div>
<!------->

I may be wrong about something, but i'm pretty sure for that last one it should change to "alert-error" instead of just "error"

@saadeghi
Copy link
Owner

Ah I see! Thank you!
Will be fixed in an hour.

@saadeghi saadeghi added the v5 label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants