Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Host_Error hook #224

Open
RauliTop opened this issue Oct 5, 2021 · 1 comment
Open

Add new Host_Error hook #224

RauliTop opened this issue Oct 5, 2021 · 1 comment

Comments

@RauliTop
Copy link
Contributor

RauliTop commented Oct 5, 2021

The idea is hook errors to create a log with them.
https://github.com/dreamstalker/rehlds/blob/1196646dcfc5e62e4801a08860596476d0e3d77f/rehlds/engine/host.cpp#L108#L139

Well, I don't know if it will work because maybe it's too late and HLDS process is closed.
Anyways, can someone test it?

The purpose is something like this: https://amxmodx-es.com/showthread.php?tid=8113

@StevenKal
Copy link

StevenKal commented Oct 8, 2021

Well, if this is only for logging, ReHLDS already has a CVar "syserror_logfile" to log such errors (in game directory), besides, you can also trying using DLL API's "pfnSys_Error" function for such logging.
But having both "<Host|Sys>_Error" functions as a hook in ReHLDS could be useful in order to prevent the server from crashing in some situations where "it could be prevented depending on the kind of error passed".
So better to request such hook chain in ReHLDS repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants