-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subcommand download #3
Comments
Why wontfix? |
The complexity to do this task is not low and, actually, this feature is beyond to the project, which is just a simple mal command line interface. This is related to #4 which have a brief discussion about the problems behind that. Even using softwares like youtube-dl, livestreamer and streamlink is not enough. The parsing to title/episode representation for multiple stream/download sources is a big task. The inconsistency of titles from MAL and the anime streams is common. And, as a user @mparadinha commented, can be not very legal too. After a complete year without any progress with it, I decided dropout this feature. If anyone to make a great proposal implementing that in a sane way, we can think again. But in general this is not priority for now, even being a useful and desired feature. Things like #41 and #46 have more priority and I, as author of the project, I'm trying keep the development more straightfoward to get at least some progress in the next months. If you have interest to contribute to the project or this specific task, welcome. PR always are welcome. But the main team will not priorize that. |
The tag |
That's fair, I understand. Just saying, instead of downloading the anime, you could just download the relevant torrent file or gather the magnet link from some websites. I assume it's not illegal either.
Something like that would be good. By the way, thanks for this project. I really like it. |
Actually this can be a good idea. Another user proposed something similar on a reddit thread another day. But him propose about return a url with video streaming content, which is fair the biggest problem from here (data inconsistency between: MAL data <=> Stream Services URL representation). About specifically this torrent-based feature, we can try look into it in the future, when the main issues has been fixed. After all, we just need use a torrent search API and get the magnet link with more seeders/leechers proportion. We can use something like TPB API. If you have interest to dig into this, we happyly merge this feature. |
Thanks, please use https://nyaa.si too. Also, they provide RSS feeds based on search queries. So, you can even implement that if there is a new episode the user haven't watched yet like this: I wish I could help but I have no understanding of Python. |
I recently made a scraper for Nyaa.si for another project. It works using the project's API but it's very trivial to modify it to work standalone. If anyone here is interested I can modify it to work standalone and you guys could use it in this project. |
Yes, I saw that before. I'm waiting your PR to be merged so then I can test the |
But I don't wanna that can be misunderstood, what I'm saying is valid yet, but I'm reconsidering implement that only for get magnet links or torrent files. Probably I should create a separated issue and implement just a Because the meaning of the command described on this issue is a bit more broad than just get torrent files or magnet links. |
@datafanatic and @kutsan I create a new issue covering a prototype about that feature (torrent/magnet-link using nyaa.si) on #64, a feedback based on your concerns would be great. A review of the design choices made will be welcome too. |
Goal (example)
download
Needs
The #2 need to be fixed before.Specification
After calling download command, this will fetch the actual episode of the lain, get the next, search on the default download server configured and save him in the actual directory.use urlretrieve and tqdm for downloadallow pass a custom directory for savingallow all alias (download all episodes)all download a specific episode with the numberThe text was updated successfully, but these errors were encountered: