-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Auto Load DLC and Latest Update #55
Comments
why don't we all work together on a project again? |
Nothing stopping amurgshere, vudjun and the others from submitting pull requests to both projects if they feel like it. On topic, amurgshere feel free to just submit the pull request if you like, regginator has been having more real-life issues that will delay him, so he won't be doing anything for the next couple of days. |
as long as we get the same level of development on forks should be good already when the time comes, well have backup repos |
Thanks @extherian and @Maskworkr , I have done this now and created this PR: Unfortunately, the Greemdev version of Ryujinx has had its Gtk UI ripped out by this commit here: So while these changes do build and work for MACOS (they do work really nicely), it's going to need additional work to integrate these changes to build into the GTK UI before we can merge it unfortunately. this is something I will do when I get the time, but just don't have the time tonight. Happy for someone else to branch of this start making these changes if they like. |
I'd just like to mention that the Autoloading functionality being merged into main Ryujinx was awaiting removal of the GTK UI, because it just didn't work properly with this addition seemingly. I dropped the GTK UI as I way prefer the Avalonia one anyways and asked J-Swift to PR the change because I knew it was just waiting on that being removed. |
Thanks @GreemDev , I agree that the GTK UI isn't the best, happy to wait and see what @regginator wants to do with this, we can either add the UI features to the GTK UI somehow, remove the GTK like you have, or not include the Auto DLC / Updates functionality yet. |
Yea, I'm down with removing the Gtk3 UI impl entirely at some point going forward (as well as the infrastructure for it of course), as the Ava impl is great. |
The ability to auto load all compatible DLC and the latest update from a specified directory or list of directories automatically would be a great feature. I found this commit here on Greemdays fork by J-Swift which accomplishes this, it would be awesome if someone could pull these changes in:
GreemDev/Ryujinx@565acec
I will do this and test when I get a chance, but created this issue in the meantime in case anyone else has time to do it before me.
The text was updated successfully, but these errors were encountered: