Issue with webcomponents that have HTML Comment elements

[spion]

Some webcomponents (like Ionic's ion-label) generate additional comment children

For those, the code frragment

dom-expressions/packages/dom-expressions/src/client.js

Line 428 in 8d2d82f

current = parent.firstChild.data = value;

is going to try and update the comment rather than the actual text content.

A repro that isn't very minimal: https://stackblitz.com/edit/github-pyx5ga?file=package.json,app%2Fclient.tsx,vite.config.js,index.html,app%2Fionic-css.ts

You will notice that <IonLabel /> generates empty comment elements, which in turn cause SolidJS to update them if the only child of the component is a string

[ryansolid]

Our system works by walking known nodes, I don't don't know if there is anything to be done here. I'm open to suggestions but if something changes the shape of the HTML from what the JSX outputs we aren't going to know where things are.