Skip to content

How to add Transactional trait #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tinkhauser opened this issue Mar 3, 2021 · 2 comments · Fixed by #4
Closed

How to add Transactional trait #2

tinkhauser opened this issue Mar 3, 2021 · 2 comments · Fixed by #4

Comments

@tinkhauser
Copy link
Contributor

I'm attempting to get the rust-radio-sx128x crate working with the nrf-hal. That hal hasn't yet implemented the v1.0.0-alpha.N embedded-hal traits.

So far compat() has solved all the trait errors except for blocking::spi::transactional. I'm unsure of how to add that trait to this crate.

Is it possible to add the transactional trait to this repo? Or do I need to fork nrf-hal and implement it there like you suggest here? rust-iot/rust-radio-sx127x#18 (comment)

Cheers!

@ryankurte
Copy link
Owner

Ahh, I didn't put it in because embedded_hal::blocking::spi::Transactional doesn't exist until v1.0.0-alpha.X...

In the past I had a polyfill for this, technically it opens a whole CS related can of worms but, might as well add have it here anyway (perhaps with a warning and link to rust-embedded/embedded-hal#180)?

@ryankurte
Copy link
Owner

ryankurte commented Mar 6, 2021

@tinkhauser i threw a Transactional trait in there so you should be good to go with 0.1.3, let me know how it goes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants