Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react peer dependency #226

Open
cristianocca opened this issue Sep 20, 2021 · 4 comments
Open

Update react peer dependency #226

cristianocca opened this issue Sep 20, 2021 · 4 comments

Comments

@cristianocca
Copy link

cristianocca commented Sep 20, 2021

Do you want to request a feature or report a bug?
bug

What is the current behavior?
Localize cannot be installed with NPM >= 7 due to peer dependency issues. Please allow react 17 in this library's peer deps.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code. Paste the link to your JSFiddle (https://jsfiddle.net/Luktwrdm/) or CodeSandbox (https://codesandbox.io/s/new) example below:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: XXX
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR! react@"17.0.2" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.0.0" from [email protected]
npm ERR! node_modules/react-localize-redux
npm ERR! react-localize-redux@"3.5.3" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

What is the expected behavior?
No dependency issues

Which versions of react and react-localize-redux are you using?
3.5.3

@cristianoccazinsp
Copy link

@ryandrewjohnson any chance for this to be updaded? Are you no longer maintaining the library?

Thanks!

@ryandrewjohnson
Copy link
Owner

I had been working on updating the library a while back but I just haven’t had the time unfortunately. At this point it’s not being actively maintained. There is a branch created for v4 if anyone wanted to ever try and pick it up.

@cristianoccazinsp
Copy link

Hi @ryandrewjohnson , looks like the library now also depends on a vulnerable package and will flag it as vulnerable (#235). I wonder if it would be possible to at least bump the dependencies. Are there any breaking changes or major code changes required? I may be willing to pick this up if it's just patching some packages.

@cristianoccazinsp
Copy link

Hello, any updates around this? Any new fork?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants