Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MESSAGE_DEFAULT_LOGGEDOFF / MESSAGE_DEFAULT_LOGGEDIN final deprecation in Moodle 4.5 #118

Open
nomisge opened this issue Oct 12, 2024 · 0 comments
Open

MESSAGE_DEFAULT_LOGGEDOFF / MESSAGE_DEFAULT_LOGGEDIN final deprecation in Moodle 4.5 #118

nomisge opened this issue Oct 12, 2024 · 0 comments

Comments

@nomisge
Copy link

nomisge commented Oct 12, 2024

In Moodle 4.5 MESSAGE_DEFAULT_LOGGEDOFF / MESSAGE_DEFAULT_LOGGEDIN have been finally deprecated.
Following Code will not work any more:

moodle-mod_pdfannotator/db/messages.php

Line 34 in ef34c0e

'popup' => MESSAGE_PERMITTED + MESSAGE_DEFAULT_LOGGEDIN + MESSAGE_DEFAULT_LOGGEDOFF,

The fix is supposedly easy: Change MESSAGE_DEFAULT_LOGGEDIN + MESSAGE_DEFAULT_LOGGEDOFF to MESSAGE_DEFAULT_ENABLED
@nomisge nomisge mentioned this issue Oct 12, 2024
Open
@nomisge nomisge changed the title MESSAGE_DEFAULT_LOGGEDOFF / MESSAGE_DEFAULT_LOGGEDIN final deprecation in Moodle 4.4 MESSAGE_DEFAULT_LOGGEDOFF / MESSAGE_DEFAULT_LOGGEDIN final deprecation in Moodle 4.5 Oct 12, 2024
@nomisge nomisge mentioned this issue Oct 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nomisge