Skip to content

New rust core PR breaks rocket_codegen on nightly #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xorl opened this issue Dec 14, 2017 · 3 comments
Closed

New rust core PR breaks rocket_codegen on nightly #503

xorl opened this issue Dec 14, 2017 · 3 comments
Labels
nightly breakage Breakage on the nightly channel only

Comments

@xorl
Copy link

xorl commented Dec 14, 2017

rust-lang/rust#46550 breaks rocket_codegen, global is now PathKind::{Global, Std, Local}

Tried to fix it locally but failed to create a working PR.

This breaks on 0.3.3. from the current nightly.

   Compiling rocket_codegen v0.3.3
error[E0560]: struct `syntax_ext::deriving::generic::ty::Path<'_>` has no field named `global`
  --> /Users/rlewon/.cargo/registry/src/github.com-1ecc6299db9ec823/rocket_codegen-0.3.3/src/decorators/derive_form.rs:76:13
   |
76 |             global: true,
   |             ^^^^^^^ `syntax_ext::deriving::generic::ty::Path<'_>` does not have this field

error[E0560]: struct `syntax_ext::deriving::generic::ty::Path<'_>` has no field named `global`
  --> /Users/rlewon/.cargo/registry/src/github.com-1ecc6299db9ec823/rocket_codegen-0.3.3/src/decorators/derive_form.rs:91:29
   |
91 |                             global: true
   |                             ^^^^^^^ `syntax_ext::deriving::generic::ty::Path<'_>` does not have this field

error[E0560]: struct `syntax_ext::deriving::generic::ty::Path<'_>` has no field named `global`
  --> /Users/rlewon/.cargo/registry/src/github.com-1ecc6299db9ec823/rocket_codegen-0.3.3/src/decorators/derive_form.rs:99:25
   |
99 |                         global: false,
   |                         ^^^^^^^ `syntax_ext::deriving::generic::ty::Path<'_>` does not have this field

error[E0560]: struct `syntax_ext::deriving::generic::ty::Path<'_>` has no field named `global`
   --> /Users/rlewon/.cargo/registry/src/github.com-1ecc6299db9ec823/rocket_codegen-0.3.3/src/decorators/derive_form.rs:109:21
    |
109 |                     global: true,
    |                     ^^^^^^^ `syntax_ext::deriving::generic::ty::Path<'_>` does not have this field

error: aborting due to 4 previous errors

error: Could not compile `rocket_codegen`.
@SergioBenitez
Copy link
Member

This has already been fixed in 4ea9b04. A new release will be made soon containing this commit.

@SergioBenitez SergioBenitez added the nightly breakage Breakage on the nightly channel only label Dec 14, 2017
@SergioBenitez
Copy link
Member

Released as v0.3.4.

@xorl
Copy link
Author

xorl commented Dec 14, 2017

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nightly breakage Breakage on the nightly channel only
Projects
None yet
Development

No branches or pull requests

2 participants