Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phalcon\Db\Profiler missing correct annotation return type #1

Open
JoeyOverby opened this issue Dec 10, 2019 · 2 comments
Open

Phalcon\Db\Profiler missing correct annotation return type #1

JoeyOverby opened this issue Dec 10, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@JoeyOverby
Copy link

    /**
     * Returns all the processed profiles
     *
     * @return array
     */
    public function getProfiles(): array
    {
    }

Should be

    /**
     * Returns all the processed profiles
     *
     * @return Phalcon\Db\Profiler\Item[]
     */
    public function getProfiles(): array
    {
    }
@ruudboon
Copy link
Owner

ruudboon commented Dec 11, 2019

Thnx. Will have a look. Probably need to fix it upstream on phalcon zephir.

@ruudboon ruudboon added the bug Something isn't working label Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants