Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The has_option method is really specific to C-Lightning #98

Open
Psycho-Pirate opened this issue Jul 13, 2023 · 0 comments
Open

The has_option method is really specific to C-Lightning #98

Psycho-Pirate opened this issue Jul 13, 2023 · 0 comments
Assignees
@vincenzopalazzo
Labels
experiment Implementing an experimental feature that we would like to have
Milestone
lnprototest 0.1.0

Comments

@Psycho-Pirate
Copy link
Contributor

In the C-Lightning runner, the options dictionary contains strings that are really specific to how C-Lightning displays its features. This makes it difficult for other runners to use this as they have to format it in the same way C-Lightning does it.
The has_option method used inside the tests also checks for these specific C-Lightning strings.
@vincenzopalazzo vincenzopalazzo added the experiment Implementing an experimental feature that we would like to have label Jul 13, 2023
@vincenzopalazzo vincenzopalazzo self-assigned this Jul 13, 2023
@vincenzopalazzo vincenzopalazzo added this to the lnprototest 0.1.0 milestone Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vincenzopalazzo vincenzopalazzo

Labels
experiment Implementing an experimental feature that we would like to have
Projects
None yet
Milestone
lnprototest 0.1.0
Development

No branches or pull requests
2 participants
@vincenzopalazzo @Psycho-Pirate