Skip to content

wasm-pack build flag docs out of date #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
twilco opened this issue Dec 17, 2018 · 5 comments
Closed

wasm-pack build flag docs out of date #462

twilco opened this issue Dec 17, 2018 · 5 comments

Comments

@twilco
Copy link
Contributor

twilco commented Dec 17, 2018

🐛 Bug description

https://rustwasm.github.io/wasm-pack/book/commands/build.html#profile

The section of this book describes three flags: --dev, --profiling, and --release, all of which result in this errored output:

$ wasm-pack build --release  
error: Found argument '--release' which wasn't expected, or isn't valid in this context

USAGE:
    wasm-pack build [FLAGS] [OPTIONS] [path]

For more information try --help

It looks like --debug is the only flag that does anything currently - no flag seems to build for release by default.

🤔 Expected Behavior

The documentation matches the behavior of the tool.

👟 Steps to reproduce

Run wasm-pack with each command and note the output.

🌍 Your environment

Include the relevant details of your environment.
wasm-pack version: 0.5.1
rustc version: rustc 1.31.0 (abe02cefd 2018-12-04)

Thanks for your work on this awesome tool!

@drager
Copy link
Member

drager commented Dec 17, 2018

Yeah, the docs are built from master and that behavior was added in #440 which targets the 0.6.0 milestone which hasn't been released yet. This means that 0.5.1 doesn't have this feature.

I think the docs at https://rustwasm.github.io/wasm-pack/book/ should be generated for multiple versions (like docs.rs does), so we can have docs for master, latest stable as well as older releases.

@twilco
Copy link
Contributor Author

twilco commented Dec 17, 2018

Got it, thanks. Any idea when 0.6.0 will be coming?

@drager
Copy link
Member

drager commented Dec 17, 2018

Not really, sorry. I think @ashleygwilliams should be able to answer that though.

@ashleygwilliams
Copy link
Member

ashleygwilliams commented Dec 17, 2018

I will be working on a release starting tomorrow, so should be sometime this week! So sorry for the delay! The Rust 2018 Edition kinda took over a bunch of my time. Now that that is over you should see both dev and release work in this pick up significantly. Sorry again!

@twilco
Copy link
Contributor Author

twilco commented Dec 18, 2018

No need to be sorry! Thanks for all your hard work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants