Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skipping .gitignore generation #728

Closed
RReverser opened this issue Oct 21, 2019 · 5 comments · May be fixed by #1131 or #1408
Closed

Allow skipping .gitignore generation #728

RReverser opened this issue Oct 21, 2019 · 5 comments · May be fixed by #1131 or #1408

Comments

@RReverser
Copy link
Member

💡 Feature description

Since implementing self-.gitignore generation in #473, I've come across few codebases that prefer not to publish npm artifacts elsewhere nor integrate Rust build into their build process, but keep any artifacts in the Git repo.

I suggest adding --no-gitignore option for such usecases.

Alternative

Since in such cases module is not intended to be published anywhere, another alternative could be to implement this (omit .gitignore) as part of --no-pack implementation proposed here #691.

cc @ashleygwilliams

@RReverser
Copy link
Member Author

Actually... I realised that this is easily worked around by using one-off git add --force pkg/... and it's even better because you can selectively include only files you need in the repo (e.g. omit package.json or .d.ts).

@David-OConnor
Copy link
Member

David-OConnor commented Oct 28, 2019

I still think this would be nice to have.

@olanod
Copy link

olanod commented Jan 25, 2020

Same, I'd like to generate only the wasm and js and skip all the extra stuff since I'm not using npm

@johnnybenson
Copy link

johnnybenson commented Feb 25, 2022

git add --force is kinda icky, .gitignore lives in a repository to codify these things for a reason. Skipping the generation of this file entirely scales better for multiple collaborators and teams because the appropriate information exists at rest.

@kixelated
Copy link

I ran into this issue when trying to publish a wrapper around the generated wasm-pack output.

src/index.ts imports ../pkg. I want to package both src and pkg into an npm package and publish it. However, bun sees the .gitignore file in pkg and skips adding it to the artifact, despite files: [ "pkg", "src" ].

$ bun pm pack --verbose
ignore [.gitignore:*] pkg/moq_web.d.ts
ignore [.gitignore:*] pkg/README.md
ignore [.gitignore:*] pkg/.gitignore
ignore [.gitignore:*] pkg/moq_web.js
ignore [.gitignore:*] pkg/moq_web_bg.js
ignore [.gitignore:*] pkg/moq_web_bg.wasm

I accidentally published a few broken versions, oops. My current work-around is to rm pkg/.gitignore after running wasm-pack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants