Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client session caching support is minimal #18

Open
ctz opened this issue May 1, 2024 · 4 comments
Open

Client session caching support is minimal #18

ctz opened this issue May 1, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@ctz
Copy link
Member

ctz commented May 1, 2024

At the moment client-side session caching only respects SSL_CTX_sess_set_cache_size, but not the cache mode, callbacks, SSL_get_session etc.

Meaningfully implementing SSL_get_session would mean rustls client sessions would need to become serialisable -- they currently are not.

@ctz ctz added the enhancement New feature or request label May 1, 2024
@ctz ctz changed the title Client session caching is minimal Client session caching support is minimal May 1, 2024
@cpu

This comment was marked as off-topic.

@ctz
Copy link
Member Author

ctz commented Jun 19, 2024

I think this issue is mostly about client-side session caching, so probably shouldn't have much bearing on nginx.

I wonder what happens if we accept the SSL_CTX_set_tlsext_ticket_key_cb but never call the callback?

To get this fully working we'd need to implement the rustls ProducesTickets trait in terms of calling the callback, then using the returned cipher and mac keys to implement the RFC5077 "recommended" construction which AIUI the openssl API is tightly coupled to.

@cpu

This comment was marked as off-topic.

@cpu
Copy link
Member

cpu commented Jun 23, 2024

I will pull the relevant comments into a new issue.

#30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants