Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Great Crate. Possible to Merge back to tokio-tls? #1

Open
Congyuwang opened this issue Jun 5, 2022 · 1 comment
Open

Great Crate. Possible to Merge back to tokio-tls? #1

Congyuwang opened this issue Jun 5, 2022 · 1 comment

Comments

@Congyuwang
Copy link

This is a great crate. The state of affair of async-tls is problematic. Its update to rustls 0.20 is still not released, whereas users are providing continuous feedback to tokio-tls.

It seems to me that futures-rustls is compatible with either tokio-tls and async-tls. Is it possible to use rust features to provide a different configuration for different needs of backends.

For example, is it possible to use features = ['tokio', 'futures'] where the default feature is 'tokio' so that tokio users won't feel any change, while enabling async-std or gio users to benefit from the community and continuous improvement of the library by enabling the 'futures' feature for their choice of backend?

@Congyuwang
Copy link
Author

I really like this crate. The code is much better than async-tls. It just feels a little bit awkward that it might need to be manually kept up to date with another crate (tokio-tls) in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant