Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(commands)!: Add lock command #163

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat(commands)!: Add lock command #163

wants to merge 8 commits into from

Conversation

aawsome
Copy link
Member

@aawsome aawsome commented Feb 16, 2024

see rustic-rs/rustic#1050

BREAKING CHANGES:

  • DeleteOptions in SnapshotFile now has more enum options.
  • Repository::save_snapshots now returns the list of Ids of the saved snapshots.

Missing points:

  • Implement locking in the backends
  • Add possibilities to lock key files
  • Add possibility to lock complete repo
  • Handle duplicate snapshots correctly - especially create at max. 1 new snapshot per "original" snapshot during lock
  • Handle locks in forget command (retention policy: only count one/the original snapshot for retention)
  • Handle locks correctly in the tag command (don't even try to remove locked snapshots)

@aawsome aawsome changed the title Add lock command feat(commands): Add lock command Feb 16, 2024
@aawsome aawsome changed the title feat(commands): Add lock command feat(commands)!: Add lock command Sep 7, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 5.81395% with 162 lines in your changes missing coverage. Please review.

Project coverage is 44.0%. Comparing base (c504c29) to head (5a11725).

Files with missing lines Patch % Lines
crates/core/src/commands/lock.rs 0.0% 98 Missing ⚠️
crates/core/src/backend/lock.rs 0.0% 23 Missing ⚠️
crates/core/src/backend/decrypt.rs 0.0% 10 Missing ⚠️
crates/core/src/repository.rs 9.0% 10 Missing ⚠️
crates/core/src/backend.rs 0.0% 7 Missing ⚠️
crates/core/src/backend/dry_run.rs 0.0% 4 Missing ⚠️
crates/core/src/repository/warm_up.rs 0.0% 3 Missing ⚠️
crates/core/src/commands/forget.rs 60.0% 2 Missing ⚠️
crates/core/src/repofile/snapshotfile.rs 33.3% 2 Missing ⚠️
crates/core/src/commands/copy.rs 0.0% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
Files with missing lines Coverage Δ
crates/core/src/backend/cache.rs 73.5% <ø> (-1.9%) ⬇️
crates/core/src/backend/hotcold.rs 0.0% <ø> (ø)
crates/core/src/error.rs 71.4% <ø> (+14.2%) ⬆️
crates/core/src/commands/copy.rs 0.0% <0.0%> (ø)
crates/core/src/commands/prune.rs 72.0% <75.0%> (-0.1%) ⬇️
crates/core/src/repofile/indexfile.rs 86.6% <66.6%> (-5.0%) ⬇️
crates/core/src/commands/forget.rs 83.9% <60.0%> (-2.9%) ⬇️
crates/core/src/repofile/snapshotfile.rs 47.9% <33.3%> (-1.2%) ⬇️
crates/core/src/repository/warm_up.rs 17.0% <0.0%> (ø)
crates/core/src/backend/dry_run.rs 12.7% <0.0%> (-1.2%) ⬇️
... and 5 more

... and 18 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant