Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic on rustic check #228

Open
hirschenberger opened this issue Jun 10, 2024 · 1 comment
Open

Panic on rustic check #228

hirschenberger opened this issue Jun 10, 2024 · 1 comment
Labels
A-errors Area: error handling needs improvement C-bug Category: Something isn't working as expected

Comments

@hirschenberger
Copy link

Rustic panics when I check my repo:

❯ rustic check
[00:00:00] reading index...               ████████████████████████████████████████        113/113
[00:00:00] listing packs...
[00:00:00] reading snapshots...           ████████████████████████████████████████        174/174
The application panicked (crashed).
Message:  called `Result::unwrap()` on an `Err` value: "SendError(..)"
Location: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rustic_core-0.2.0/src/blob/tree.rs:500

When I enable backtraces it doesn't for some strage reason:

❯ RUST_BACKTRACE=1 rustic check
[00:00:00] reading index...               ████████████████████████████████████████        113/113
[00:00:01] listing packs...
[00:00:00] reading snapshots...           ████████████████████████████████████████        174/174
error: blob e3a8ce3ac99b27096ae79e8ccc86321764515ba2a8a21e978ae609ed587a13f8 not found in index
❯ rustic --version
rustic 0.7.0

Installed via cargo binstall

@github-actions github-actions bot added the S-triage Status: Waiting for a maintainer to triage this issue/PR label Jun 10, 2024
@nardoor
Copy link
Contributor

nardoor commented Sep 5, 2024

Hello,

Thanks taking the time to fill an issue!
I am sorry for my late response.

I am thinking that crates/core/src/blob/tree.rs:691 caused this.
But I'd like to understand better what led to this issue.

Would you be able to describe your setup?
If you are able to reproduce this from the creation of a new repository to this panic, this would allow us to reproduce the issue and help understand why it happened.

On a side note, the unwrap will at some point be replaced by some clean error handling. some unecessary unwrap remain for now as rustic is at its early stage.

@nardoor nardoor added A-errors Area: error handling needs improvement C-bug Category: Something isn't working as expected and removed S-triage Status: Waiting for a maintainer to triage this issue/PR labels Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-errors Area: error handling needs improvement C-bug Category: Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

2 participants