Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EGL: Provide color-space support #1658

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

EGL: Provide color-space support #1658

wants to merge 1 commit into from

Conversation

MarijnS95
Copy link
Member

@MarijnS95 MarijnS95 commented Dec 21, 2023 •
edited
Loading

Closes #1653

Still a few things to do, such as:

  • writing a commit message;
  • addressing TODOs;
  • deciding where to go with EglSurfaceAttributes since it's so easy to get wrong;
  • Remove unneeded changes from the example.

MarijnS95
MarijnS95 commented Dec 24, 2023
View reviewed changes
glutin/src/surface.rs Outdated Show resolved Hide resolved
MarijnS95
MarijnS95 commented Dec 24, 2023
View reviewed changes
glutin_egl_sys/build.rs Outdated Show resolved Hide resolved
@kchibisov
Copy link
Member

Do you want me to look into something specific here given that you have it as a draft and have a bunch of debug in the code?

@MarijnS95 MarijnS95 mentioned this pull request Mar 6, 2024
Merged
@MarijnS95
Copy link
Member Author

@kchibisov sure the example used to contain a full setup for using EGL HDR color spaces.

As this is "the only" example in glutin I surely feel that shouldn't immediately expose the user to a completely EGL-specific color space setup, especially if we don't even go to lengths to use the right colors in other spaces. I've now dropped that from this PR. If you think we should, I could always reintroduce it as a separate example app (though wouldn't wish to duplicate 90% of the current example... 😅).

This PR still contains some drive-by ideas to make it easier to work with "HDR" surfaces, such as maybe making it more straightforward to create a ConfigTemplateBuilder for different "popular" formats?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kchibisov kchibisov Awaiting requested review from kchibisov

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Design considerations for HDR colorspace support
2 participants
@MarijnS95 @kchibisov