Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sound: tasks to move vhost-device-sound from staging #578

Closed
3 tasks done
MatiasVara opened this issue Dec 12, 2023 · 9 comments
Closed
3 tasks done

sound: tasks to move vhost-device-sound from staging #578

MatiasVara opened this issue Dec 12, 2023 · 9 comments

Comments

@MatiasVara
Copy link
Contributor

MatiasVara commented Dec 12, 2023

The purpose of this issue is to figure out what needs to be done to move vhost-device-sound from staging. Some of the tasks are:

Is there anything else we need to do?

Thanks.

@epilys
Copy link
Member

epilys commented Dec 12, 2023

Sorry if I'm repeating myself, I legitimately don't remember where we settled for this; do we want musl builds or not?

@Ablu
Copy link
Contributor

Ablu commented Dec 13, 2023

Sorry if I'm repeating myself, I legitimately don't remember where we settled for this; do we want musl builds or not?

IIRC nobody was against disabling them where they do not make sense. But I am not sure whether we agreed on a way to do that.

@stefano-garzarella
Copy link
Member

Sorry if I'm repeating myself, I legitimately don't remember where we settled for this; do we want musl builds or not?

IIRC we agreed on disable musl build for the sound device. The problem was how. @Ablu suggested to take a look at the gpio device. I tried to see if we can do something in Cargo.toml, but without success. So IMHO for now we can do something similar of what we did in gpio.

@stefano-garzarella
Copy link
Member

About alsa test, is someone working on it? (otherwise, I think we can put it in the exclude_path)

@epilys
Copy link
Member

epilys commented Dec 13, 2023

See #579

@stsquad
Copy link
Collaborator

stsquad commented Jan 8, 2024

Can this be closed now?

@MatiasVara
Copy link
Contributor Author

Can this be closed now?

We are thinking to keep it open until https://gitlab.freedesktop.org/pipewire/pipewire-rs/-/merge_requests/210 is merged, if that's OK.

@MatiasVara
Copy link
Contributor Author

MatiasVara commented Jan 18, 2024

MR 210 has been merged, I'll close this issue after #606 is merged.

@stefano-garzarella
Copy link
Member

#606 is now merged, closing this ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants