Skip to content

Correctly expose CpuId related items #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dianpopa opened this issue Apr 3, 2019 · 3 comments
Closed

Correctly expose CpuId related items #16

dianpopa opened this issue Apr 3, 2019 · 3 comments
Assignees
@acatangiu

Comments

@dianpopa
Copy link
Contributor

dianpopa commented Apr 3, 2019

There are 2 issues identified here:

  • MAX_KVM_CPUID_ENTRIES is a x86_64 specific constant and should be labeled as such.
  • We also need to publicly expose CpuId wrapper since it needs to be accessible from outside.
@andreeaflorescu
Copy link
Member

We also need KvmRunWrapper and Result.
@sameo is partially working on this.

@andreeaflorescu
Copy link
Member

Just notice that #14 already mentions these issues. @dianpopa can you update it to only mention the MAX_KVM_CPUID_ENTRIES issue?

@andreeaflorescu andreeaflorescu mentioned this issue Oct 8, 2019
Closed
@acatangiu acatangiu self-assigned this Nov 13, 2019
@acatangiu
Copy link
Collaborator

Fixed by #64

This crate no longer exports MAX_KVM_CPUID_ENTRIES.
KVM_MAX_CPUID_ENTRIES is defined and exported by the kvm-bindings crate only on x86_64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acatangiu acatangiu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andreeaflorescu @dianpopa @acatangiu