Use timestamps for change detection #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the caching mechanism to use the timestamp of all included templates instead of hashing the contents of the root template. The primary downside is that every build now has to parse, transform, and resolve the input templates instead of just reading and hashing the data--I didn't measure how much more expensive this is, but it seems unavoidable if we need information about child templates. Maybe a hacky regex-based approach could work as an alternative to a complete parse. On the bright side, this approach rebuilds parent templates correctly when a child template has changed, and doesn't require garbage collection for old compiled template files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the caching mechanism to use the timestamp of all included templates instead of hashing the contents of the root template.
The primary downside is that every build now has to parse, transform, and resolve the input templates instead of just reading and hashing the data--I didn't measure how much more expensive this is, but it seems unavoidable if we need information about child templates. Maybe a hacky regex-based approach could work as an alternative to a complete parse.
On the bright side, this approach rebuilds parent templates correctly when a child template has changed, and doesn't require garbage collection for old compiled template files.
Checked correctness manually by setting
CARGO_LOG=cargo::core::compiler::fingerprint=info.Fixes #134 (maybe related to #132?).