From 5a0eb98cb575f0e06d69fe8cf0cbb1bc10113b56 Mon Sep 17 00:00:00 2001 From: Vinzent Steinberg Date: Thu, 14 Dec 2023 08:57:34 +0100 Subject: [PATCH 1/4] Add workflow for clippy --- .github/workflows/rust-clippy.yml | 54 +++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+) create mode 100644 .github/workflows/rust-clippy.yml diff --git a/.github/workflows/rust-clippy.yml b/.github/workflows/rust-clippy.yml new file mode 100644 index 0000000000..0ea6882763 --- /dev/null +++ b/.github/workflows/rust-clippy.yml @@ -0,0 +1,54 @@ +# This workflow uses actions that are not certified by GitHub. +# They are provided by a third-party and are governed by +# separate terms of service, privacy policy, and support +# documentation. +# rust-clippy is a tool that runs a bunch of lints to catch common +# mistakes in your Rust code and help improve your Rust code. +# More details at https://github.com/rust-lang/rust-clippy +# and https://rust-lang.github.io/rust-clippy/ + +name: rust-clippy analyze + +on: + push: + branches: [ "master", "0.[0-9]" ] + pull_request: + # The branches below must be a subset of the branches above + branches: [ "master" ] + schedule: + - cron: '28 7 * * 6' + +jobs: + rust-clippy-analyze: + name: Run rust-clippy analyzing + runs-on: ubuntu-latest + permissions: + contents: read + security-events: write + steps: + - name: Checkout code + uses: actions/checkout@v2 + + - name: Install Rust toolchain + uses: actions-rs/toolchain@16499b5e05bf2e26879000db0c1d13f7e13fa3af #@v1 + with: + profile: minimal + toolchain: stable + components: clippy + override: true + + - name: Install required cargo + run: cargo install clippy-sarif sarif-fmt + + - name: Run rust-clippy + run: + cargo clippy + --all-features + --message-format=json | clippy-sarif | tee rust-clippy-results.sarif | sarif-fmt + continue-on-error: true + + - name: Upload analysis results to GitHub + uses: github/codeql-action/upload-sarif@v1 + with: + sarif_file: rust-clippy-results.sarif + wait-for-processing: true From 504ede782270414365bb7f1b897a9562718a4d17 Mon Sep 17 00:00:00 2001 From: Vinzent Steinberg Date: Thu, 14 Dec 2023 22:38:02 +0100 Subject: [PATCH 2/4] Clippy: Build all crates for default features --- .github/workflows/rust-clippy.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/rust-clippy.yml b/.github/workflows/rust-clippy.yml index 0ea6882763..18de833388 100644 --- a/.github/workflows/rust-clippy.yml +++ b/.github/workflows/rust-clippy.yml @@ -43,7 +43,7 @@ jobs: - name: Run rust-clippy run: cargo clippy - --all-features + --all --message-format=json | clippy-sarif | tee rust-clippy-results.sarif | sarif-fmt continue-on-error: true From fb97ecc7413a8de60861599e842f7abbb882761d Mon Sep 17 00:00:00 2001 From: Vinzent Steinberg Date: Thu, 14 Dec 2023 22:51:00 +0100 Subject: [PATCH 3/4] Prefer https links --- rand_chacha/src/chacha.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rand_chacha/src/chacha.rs b/rand_chacha/src/chacha.rs index ebc28a8ab0..9139e1a8e0 100644 --- a/rand_chacha/src/chacha.rs +++ b/rand_chacha/src/chacha.rs @@ -138,7 +138,7 @@ macro_rules! chacha_impl { /// https://cr.yp.to/chacha.html) /// /// [^2]: [eSTREAM: the ECRYPT Stream Cipher Project]( - /// http://www.ecrypt.eu.org/stream/) + /// https://www.ecrypt.eu.org/stream/) #[derive(Clone, Debug)] pub struct $ChaChaXRng { rng: BlockRng<$ChaChaXCore>, From 2fc8f9ce3363d7fbbe3a0f3f39feb4522ae5bc5d Mon Sep 17 00:00:00 2001 From: Vinzent Steinberg Date: Thu, 14 Dec 2023 22:57:09 +0100 Subject: [PATCH 4/4] rand_distr: Update dependencies --- rand_distr/Cargo.toml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rand_distr/Cargo.toml b/rand_distr/Cargo.toml index 9d3baee0a8..12ff810d77 100644 --- a/rand_distr/Cargo.toml +++ b/rand_distr/Cargo.toml @@ -37,6 +37,6 @@ rand_pcg = { version = "0.4.0", path = "../rand_pcg" } # For inline examples rand = { path = "..", version = "0.9.0", features = ["small_rng"] } # Histogram implementation for testing uniformity -average = { version = "0.13", features = [ "std" ] } +average = { version = "0.14", features = [ "std" ] } # Special functions for testing distributions -special = "0.8.1" +special = "0.10"