Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rand-0.5.0-pre.2 release, please? #447

Closed
isislovecruft opened this issue May 15, 2018 · 8 comments
Closed

Make rand-0.5.0-pre.2 release, please? #447

isislovecruft opened this issue May 15, 2018 · 8 comments

Comments

@isislovecruft
Copy link

Hi!

I was wondering if it would be possible to get a rand-0.5.0-pre.2 pre-release made, since… well… my colleagues and I appear to have gotten ourselves into a bit of a mismatched dependency hell. curve25519-dalek-0.17 is about to require rand = "^0.5.0-pre" because we need the impl CryptoRng for OsRng (which was added in #414, after the last pre-release). However, in tor, we're currently pinned to rand-0.5.0-pre.1 because I needed to implement a custom RNG using the rand_core::RngCore trait, which then of course required using 0.5 (and the latest at the time was rand-0.5.0-pre.1).

So, if it's possible and something you're willing to do, getting a new pre-release and putting that into dalek would allow us to do one of our current tasks for using Rust for signing and verification in tor, which would be super rad!

Thanks for all the work you do!

@dhardy
Copy link
Member

dhardy commented May 15, 2018

The plan is to release this pre-release very soon actually, and probably the final 0.5 soon after.

@dhardy
Copy link
Member

dhardy commented May 15, 2018

In fact @pitdicker if you're happy to merge #411 and rebase #423, I can make a pre-release from that. Doc doesn't need to be in its final form for the pre-release.

@pitdicker
Copy link
Contributor

I think I'm done in about an hour revising #423.

@dhardy
Copy link
Member

dhardy commented May 15, 2018

@dhardy dhardy closed this as completed May 15, 2018
@pitdicker
Copy link
Contributor

How did you make the release? I don't see a version bump etc. on master yet.

@dhardy
Copy link
Member

dhardy commented May 15, 2018

Sorry, I forgot to push that.

@isislovecruft
Copy link
Author

Wow, that was blazingly fast, thanks!

@dhardy
Copy link
Member

dhardy commented May 15, 2018

I think it's somewhat coincidence actually 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants