Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump MSRV for rand 0.8 #1009

Closed
vks opened this issue Aug 1, 2020 · 4 comments
Closed

Bump MSRV for rand 0.8 #1009

vks opened this issue Aug 1, 2020 · 4 comments

Comments

@vks
Copy link
Collaborator

vks commented Aug 1, 2020

TryFrom was stabilized with 1.34 and may allow us to get rid of some unsafe code. This is only a small bump from our current MSRV 1.32.

Are there any features that would justify a larger bump?
@newpavlov
Copy link
Member

It would be nice to bump MSRV to 1.36 for a more straightforward alloc support.

@dhardy
Copy link
Member

dhardy commented Aug 1, 2020

1.36 is over a year old. I don't believe there's a very good rationale for supporting anything older (even if I have been guilty of arguing against MSRV bumps too often).

@vks
Copy link
Collaborator Author

vks commented Aug 1, 2020

I agree, but this issue was more about possibly supporting a more recent version.

@dhardy
Copy link
Member

dhardy commented Aug 28, 2020

Done in #1011.

@dhardy dhardy closed this as completed Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vks @dhardy @newpavlov