Skip to content

Commit 41b8981

Browse files
authored
Allow Edge tests to fail (#339)
Window's `msedgedriver` seems to be unreliable, as port binding will occasionally fail. Instead of wasting time trying to debug this, just let the tests fail. We take a similar approch for Safari's webdriver, we will allow the tests to fail, but will hopefully see when they start succeeding (when Safari fixes the COOP bug). Signed-off-by: Joe Richey <[email protected]>
1 parent 74a2021 commit 41b8981

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

.github/workflows/tests.yml

+9-7
Original file line numberDiff line numberDiff line change
@@ -195,9 +195,8 @@ jobs:
195195
host: x86_64-unknown-linux-musl
196196
- os: windows-2022
197197
host: x86_64-pc-windows-msvc
198-
# Re-enable when Safari tests start working
199-
# - os: macos-12
200-
# host: x86_64-apple-darwin
198+
- os: macos-12
199+
host: x86_64-apple-darwin
201200
runs-on: ${{ matrix.os }}
202201
steps:
203202
- uses: actions/checkout@v3
@@ -220,11 +219,14 @@ jobs:
220219
run: wasm-pack test --headless --chrome --features=js,test-in-browser
221220
- name: Test (Edge)
222221
if: runner.os == 'Windows'
222+
# Edge has flaky failures: "driver failed to bind port during startup"
223+
continue-on-error: true
223224
run: wasm-pack test --headless --chrome --chromedriver $Env:EDGEWEBDRIVER\msedgedriver.exe --features=js,test-in-browser
224-
# Safari tests are broken: https://github.com/rustwasm/wasm-bindgen/issues/3004
225-
# - name: Test (Safari)
226-
# if: runner.os == 'macOS'
227-
# run: wasm-pack test --headless --safari --features=js,test-in-browser
225+
- name: Test (Safari)
226+
if: runner.os == 'macOS'
227+
# Safari tests are broken: https://github.com/rustwasm/wasm-bindgen/issues/3004
228+
continue-on-error: true
229+
run: wasm-pack test --headless --safari --features=js,test-in-browser
228230
- name: Test (custom getrandom)
229231
run: wasm-pack test --node --features=custom
230232

0 commit comments

Comments
 (0)