Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default epsilon implementation for Float #232

Closed
AtheMathmo opened this issue Sep 22, 2016 · 1 comment
Closed

Remove default epsilon implementation for Float #232

AtheMathmo opened this issue Sep 22, 2016 · 1 comment
Labels
breaking change

Comments

@AtheMathmo
Copy link
Contributor

With #231 we introduced a new epsilon() function which returns the EPSILON constant for f32 and f64. In order to prevent breaking the API we provided a default implementation here - using NumCast to return f32::EPSILON.

When we are ready to release breaking changes we should consider removing this default implementation.
remexre pushed a commit to remexre/num that referenced this issue Jun 1, 2017
@dtolnay
Merge pull request rust-num#232 from frewsxcv/bump
2f75aba 
Bump 'itoa' and 'dtoa' dependencies.
@cuviper cuviper mentioned this issue Dec 19, 2017
Closed
@cuviper
Copy link
Member

cuviper commented Dec 19, 2017

This issue was moved to rust-num/num-traits#4

@cuviper cuviper closed this as completed Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cuviper @AtheMathmo