From d64caa6dbe4e0e839d0cd6201652f655034e9023 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jakub=20Ber=C3=A1nek?= <berykubik@gmail.com>
Date: Tue, 18 Feb 2025 16:12:56 +0100
Subject: [PATCH] Temporarily remove DB assignment tests

Assignment based on review preferences is not working currently.
---
 src/handlers/assign.rs                        |  1 -
 src/handlers/assign/tests/tests_db.rs         | 34 -------------------
 src/handlers/pr_tracking.rs                   |  1 -
 .../pull_requests_assignment_update.rs        |  4 +--
 4 files changed, 2 insertions(+), 38 deletions(-)
 delete mode 100644 src/handlers/assign/tests/tests_db.rs

diff --git a/src/handlers/assign.rs b/src/handlers/assign.rs
index bf880d52..7ef91540 100644
--- a/src/handlers/assign.rs
+++ b/src/handlers/assign.rs
@@ -39,7 +39,6 @@ use tracing as log;
 #[cfg(test)]
 mod tests {
     mod tests_candidates;
-    mod tests_db;
     mod tests_from_diff;
 }
 
diff --git a/src/handlers/assign/tests/tests_db.rs b/src/handlers/assign/tests/tests_db.rs
deleted file mode 100644
index 825e0945..00000000
--- a/src/handlers/assign/tests/tests_db.rs
+++ /dev/null
@@ -1,34 +0,0 @@
-#[cfg(test)]
-mod tests {
-    use crate::handlers::assign::filter_by_capacity;
-    use crate::tests::run_test;
-    use std::collections::HashSet;
-    use tokio_postgres::GenericClient;
-
-    #[tokio::test]
-    async fn find_reviewers_no_review_prefs() {
-        run_test(|ctx| async move {
-            ctx.add_user("usr1", 1).await;
-            ctx.add_user("usr2", 2).await;
-            let _users = filter_by_capacity(
-                ctx.db_client().await.client(),
-                &candidates(&["usr1", "usr2"]),
-            )
-            .await?;
-            // FIXME: this test fails, because the query is wrong
-            // check_users(users, &["usr1", "usr2"]);
-            Ok(ctx)
-        })
-        .await;
-    }
-
-    fn candidates(users: &[&'static str]) -> HashSet<&'static str> {
-        users.into_iter().copied().collect()
-    }
-
-    fn check_users(users: HashSet<String>, expected: &[&'static str]) {
-        let mut users: Vec<String> = users.into_iter().collect();
-        users.sort();
-        assert_eq!(users, expected);
-    }
-}
diff --git a/src/handlers/pr_tracking.rs b/src/handlers/pr_tracking.rs
index 542df5cf..6824fe7f 100644
--- a/src/handlers/pr_tracking.rs
+++ b/src/handlers/pr_tracking.rs
@@ -7,7 +7,6 @@
 //! - Removes the PR from the workqueue of one team member (after the PR has been unassigned or closed)
 
 use crate::github::{User, UserId};
-use crate::handlers::assign::FindReviewerError;
 use crate::{
     config::ReviewPrefsConfig,
     github::{IssuesAction, IssuesEvent},
diff --git a/src/handlers/pull_requests_assignment_update.rs b/src/handlers/pull_requests_assignment_update.rs
index cdb31394..a9092624 100644
--- a/src/handlers/pull_requests_assignment_update.rs
+++ b/src/handlers/pull_requests_assignment_update.rs
@@ -1,5 +1,5 @@
-use crate::db::users::record_username;
-use crate::github::retrieve_pull_requests;
+use crate::github::{retrieve_open_pull_requests, UserId};
+use crate::handlers::pr_tracking::{PullRequestNumber, ReviewerWorkqueue};
 use crate::jobs::Job;
 use async_trait::async_trait;
 use std::collections::{HashMap, HashSet};